Workarround adventure breaking translatable comments #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Herrera <[email protected]>
Pablete1234
force-pushed
the
workarround-adventure
branch
from
2a2f6d6
to
8f548f5
Compare
cswhite2000
approved these changes
Aug 22, 2023
Electroid
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adventure has a ViaFacet$Chat class, which sends text using 1.16 format for support for hex codes. The issue is by doing that, it skips all translation layers from 1.8 to 1.16, including a needed rename for translated items to work. Removing this means hex colors would be restricted to the 16 colors even for 1.16 clients (pgm doesn't use them) but translations will be correct.
With fix:
Without fix:
Note, we already tried reaching with an issue in adventure, but got no response: KyoriPowered/adventure-platform#137