Fix leave messages sometimes showing for vanished players #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher White <[email protected]>
Pablete1234
approved these changes
Sep 10, 2023
Electroid
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When players vanish by joining through a vanish subdomain, they sometimes show regular leaves messages when they disconnect.
This was caused by the vanish removal listener and the quit announce listener having the same priority https://github.com/PGMDev/PGM/blob/dev/core/src/main/java/tc/oc/pgm/listeners/JoinLeaveAnnouncer.java#L42
I've raised the priority of the vanish remove listener so that it happens after the leave message is announced.