Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant improvements in pools & map command #1250

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

Pablete1234
Copy link
Member

@Pablete1234 Pablete1234 commented Oct 1, 2023

Adds an option for pools to specify a list of variants, the maps will try to load their variants if any are available, in order:

pools:
  halloween:
    # Other stuff omitted for clarity
    variants:
      - halloween
      - hallo
    maps:
      - Map A
      - Map B

If any of the maps Map A or Map B have a variant with id "halloween", it will load that instead. If it doesn't have one of those, it will fall-back to "hallo", and if all fails it will end up with the default variant of the map.

Variants now also show up in /map, and you can click to look thru them:
image

Additionally, added a has-variant conditional:

<if has-variant="halloween">
  <unless variant="halloween">
    <phase>development</phase>
  </unless>
</if>

If put in the global xml, this would automatically dev-phase all non-halloween variants, for maps that have a halloween variant.

cswhite2000
cswhite2000 previously approved these changes Oct 1, 2023
@Pablete1234 Pablete1234 added the ready PR is ready to merge label Oct 8, 2023
@Electroid Electroid merged commit 24cf489 into dev Oct 9, 2023
2 checks passed
@Electroid Electroid deleted the variant-improvements branch October 9, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is ready to merge
Development

Successfully merging this pull request may close these issues.

3 participants