Add support for deleting nodes with constants #1256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straight up taken from #1181:
3.4.1 Support deleting attributes using the constant
A consideration was that constants maybe should support "deleting" the attribute, example:
In here we want the ranked version to have max=8, max-overfill=8, and the default to have max=32, and no max-overfill at all.
Being able to set the constant to "no value" (via delete="true" to signal that you clearly are doing this on purpose, it's not that you forgot the value), it would strip the whole attribute.