-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a timelimit variable #1260
Add a timelimit variable #1260
Conversation
62839b4
to
b3d43be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the two minor things i mentioned, looks good to me
However, i thought we were going to have timelimit actually implemented as a variable instead of an action, which gives the flexibility to change it more arbitrarily (eg: +120 for adding 2 mins to tl)
Right, I forgot we had this discussion |
Switched to a timelimit variable with example usage: <variables>
<timelimit id="tl_2"/>
</variables>
...
in actions:
<set var="tl_2" value="60"/> Other behaviour: Negative time limits cancel the timer. |
6aa6809
to
ab27b28
Compare
core/src/main/java/tc/oc/pgm/variables/types/TimeLimitVariable.java
Outdated
Show resolved
Hide resolved
core/src/main/java/tc/oc/pgm/variables/types/TimeLimitVariable.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Christopher White <[email protected]>
Adds a match scoped
timelimit
actionBehaves like the command
Example:
All attributes are optional.
This has all of the same optional arguments as the command.
For @zzufx