Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timelimit variable #1260

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Add a timelimit variable #1260

merged 1 commit into from
Mar 10, 2024

Conversation

cswhite2000
Copy link
Member

@cswhite2000 cswhite2000 commented Oct 22, 2023

Adds a match scoped timelimit action

Behaves like the command

Example:

<timelimit duration="10s" result="objectives"/>

All attributes are optional.

This has all of the same optional arguments as the command.

For @zzufx

@cswhite2000 cswhite2000 added the feature New feature or request label Oct 22, 2023
@cswhite2000 cswhite2000 force-pushed the tl-action branch 2 times, most recently from 62839b4 to b3d43be Compare October 23, 2023 01:43
Copy link
Member

@Pablete1234 Pablete1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the two minor things i mentioned, looks good to me

However, i thought we were going to have timelimit actually implemented as a variable instead of an action, which gives the flexibility to change it more arbitrarily (eg: +120 for adding 2 mins to tl)

@cswhite2000
Copy link
Member Author

However, i thought we were going to have timelimit actually implemented as a variable instead of an action

Right, I forgot we had this discussion
Probably would be better to implement it that way

@cswhite2000
Copy link
Member Author

Switched to a timelimit variable with example usage:

<variables>
	<timelimit id="tl_2"/>
</variables>

...
in actions:
<set var="tl_2" value="60"/>

Other behaviour:

Negative time limits cancel the timer.
A time-limit of 0 will instantly end the match

@cswhite2000 cswhite2000 changed the title Add a timelimit action Add a timelimit variable Mar 9, 2024
@cswhite2000 cswhite2000 force-pushed the tl-action branch 2 times, most recently from 6aa6809 to ab27b28 Compare March 9, 2024 00:47
Signed-off-by: Christopher White <[email protected]>
@Pablete1234 Pablete1234 added the ready PR is ready to merge label Mar 10, 2024
@Electroid Electroid merged commit ac7b590 into dev Mar 10, 2024
2 checks passed
@Electroid Electroid deleted the tl-action branch March 10, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request ready PR is ready to merge
Development

Successfully merging this pull request may close these issues.

3 participants