Fix duplicate inline filter references not working #1263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes duplicate inline filters complaining about no two filters being able to use the same id, when used as child nodes and not attributes.
In this scenario, pgm would complain that
all(round-1, round-1-finished)
is a duplicate id, because it is assuming it needs to register it, due to not being anXMLFilterReference
(it's an all filter). This PR makes it so if a reference xml creation is for an already defined filter, it will use that one instead of creating a new one. That solves both not finding, and also adds caching to re-used inline filters that get used like this.