Enable removal of the DoubleJumpKit 🐸 #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: applenick <[email protected]>
Pablete1234
approved these changes
Nov 14, 2023
Electroid
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the removal of the
DoubleJumpKit. I just tested locally, and it functions as expected 👍One minor note: I also added a
removeChargemethod to theDoubleJumpMatchModule. Basically removes the xp set to make it more clear that the kit has been removed, as opposed to leaving it partially or fully filled. I believe that's best approach, but just let me know if there's an alternate way to go about this.