fix(ci): pin maven-surefire-plugin to 3.1.2 #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTtie
force-pushed
the
fix/failing-textexception-tests
branch
from
7b5e830
to
fe75917
Compare
Pinning this is needed to resolve discrepancies between GHA and local builds (GHA resolves to 2.12.4 - which does not run all tests [1], local clones across my fleet resolve to 3.0.0 - which runs all tests present, one of which is failing, but that will be resolved in a later commit) [1]: https://github.com/PGMDev/PGM/actions/runs/6867090484/job/18674723190#step:4:151 Signed-off-by: TTtie <[email protected]>
Using tc.oc.pgm.util.text.Audience requires a running Bukkit instance. Accessing it from a test (where a Bukkit instance is N/A) therefore crashes the test, making it fail. Signed-off-by: TTtie <[email protected]>
Instead of checking for whether the JVM is in English and then checking for a static string (which probably changed in the meantime), reconstruct the translated error manually and compare the results. This makes the test environment agnostic. Signed-off-by: TTtie <[email protected]>
TTtie
force-pushed
the
fix/failing-textexception-tests
branch
from
fe75917
to
5d32ef5
Compare
Electroid
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins
maven-surefire-pluginto version3.1.2to resolve build failures for local builds due to resolution algorithm changes in Maven 3.9.x.On GitHub Actions (and my server running Maven 3.8.7 from Debian repositories),
maven-surefire-pluginresolves to version2.12.4– which makes the build pass, but also seems to skip a significant portion of defined tests1.However, when building PGM locally (using Maven 3.9.1 from Fedora's repositories),
maven-surefire-pluginis resolved to version3.0.0(or higher), which runs all of the defined tests. Building with Maven 3.9.5 on CI runs all defined tests, skipping theTextExceptionclass test that is otherwise failing, likely due to the JVM running using a different locale2. This makes PGM build successfully on CI under newer Maven versions.This PR also fixes a broken test of the
TextExceptionclass which is crashing due to a missing Bukkit instance whentc.oc.pgm.util.text.Audienceis accessed by getting the emptyAudiencedirectly. Along with this, the test for localized messages has been improved to be environment agnostic by translating the error manually using the same steps asTextExceptiondoes and comparing the results appropriately.Footnotes
https://github.com/PGMDev/PGM/actions/runs/6867090484/job/18674723190#step:4:151 ↩
https://github.com/TTtie/PGM/actions/runs/6961974625/job/18944710722#step:6:708 ↩