Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and use non-deprecated methods (take 2) #1281

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

calcastor
Copy link
Contributor

@calcastor calcastor commented Dec 5, 2023

THIS DEPENDS ON Electroid/SportPaper#136 FOR COMMUNITY TO WORK PROPERLY

The latest versions of Adventure require newer Gson than is in SportPaper. This is an issue for cross-server chat in Community, which requires Adventure functions that use newer Gson functionality. Given that Community does not support Spigot, this should be fine to merge so long as the above SportPaper PR is merged.

If or when Community supports Spigot (which seems unlikely without a loss in functionality compared to SportPaper), a workaround of sorts may be needed on its end.

@Electroid Electroid merged commit f84e57b into PGMDev:dev Apr 12, 2024
2 checks passed
@calcastor calcastor deleted the updates-again branch June 14, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is ready to merge
Development

Successfully merging this pull request may close these issues.

4 participants