Avoid reflection when using SportPaper #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcastor
force-pushed
the
java-17-sportpaper
branch
from
83d3bab
to
b2f56f4
Compare
|
This has been updated to add a fallback for older versions of SportPaper. However, it does now depend on newer versions of SportPaper to build thus the action failure. |
Pablete1234
reviewed
Jan 12, 2024
util/src/main/java/tc/oc/pgm/util/nms/v1_8/NMSHacksSportPaper.java
Outdated
Show resolved
Hide resolved
calcastor
force-pushed
the
java-17-sportpaper
branch
2 times, most recently
from
2da97b5
to
a8527af
Compare
calcastor
force-pushed
the
java-17-sportpaper
branch
from
a8527af
to
dc0e5f7
Compare
|
@Electroid The relevant PR for this has been merged in SportPaper however it does not seem to be deployed to the Maven repo for SportPaper. Any ideas? |
calcastor
force-pushed
the
java-17-sportpaper
branch
from
dc0e5f7
to
b20fb85
Compare
The reflection used in NMSHacks1_8 breaks in modern Java versions, but we can modify SportPaper to avoid that here. Signed-off-by: BT (calcastor/mame) <[email protected]>
calcastor
force-pushed
the
java-17-sportpaper
branch
from
b20fb85
to
6a0c4c9
Compare
Signed-off-by: BT (calcastor/mame) <[email protected]>
calcastor
force-pushed
the
java-17-sportpaper
branch
from
6a0c4c9
to
89f10a3
Compare
|
GitHub actions doesn't seem to like the pgm.fyi maven repo, but with snapshots enabled for the SportPaper maven repo the build succeeds here now. That seems to be only permitted for authenticated GitHub users, however the pgm.fyi maven repo does seem to work fine for local builds. |
cswhite2000
approved these changes
Mar 10, 2024
Electroid
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Electroid/SportPaper#139The reflection used in NMSHacks1_8 breaks in modern Java versions, but we can modify SportPaper and avoid that here.