Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constant attr inheritance & defined_value conditional default #1381

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Pablete1234
Copy link
Member

Fixes the fallback attribute not being respected if defined like:

<constants fallback="true">
  <constant id="a">b</constant>
</constants>

Additionally the default constant-comparison will be defined value instead of defined, as it seems like the more reasonable default as you probably don't want to include a block if it's deleted. This could be considered a breaking change but it's been in dev for literally a day, so i think it will be fine

@Pablete1234 Pablete1234 added the bug Something isn't working label Aug 12, 2024
@Pablete1234 Pablete1234 merged commit 0f12054 into dev Aug 12, 2024
2 checks passed
@Pablete1234 Pablete1234 deleted the minor-constant-fixes branch August 12, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants