Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a cross-version sounds interface #1399

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

calcastor
Copy link
Contributor

Closes #1395

Pablete1234 and others added 3 commits September 17, 2024 23:14
Signed-off-by: Pablo Herrera <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
Pablete1234
Pablete1234 previously approved these changes Sep 25, 2024
Copy link
Member

@Pablete1234 Pablete1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, otherwise looks good

util/src/main/java/tc/oc/pgm/util/bukkit/Sounds.java Outdated Show resolved Hide resolved
Signed-off-by: Pablo Herrera <[email protected]>
@Pablete1234 Pablete1234 merged commit fccf7ba into PGMDev:dev Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Sound keys need to be version-dependant
2 participants