Implement fluent parser & start migration #1408
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long while, PGM has had an explosion of parsing methods to support the different ways in which we can parse. Overloads upon overloads for parsing a node, an element, an attribute, required or with a default, maybe with a validation in there too.
That doesn't create the cleanest programming model, and it's why i want to move away from it. Welcome fluent parsing api:
This is just a specific example for filters (listing all 10 former methods) but the new api also comes with more methods like
optional(defaultValue)
of whichorAllow
is just an overload specifically for filters. The beauty is we can compose these calls without having an explosion in method overloads.