Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add potion effect improvements for modern #1441

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Add potion effect improvements for modern #1441

merged 1 commit into from
Nov 25, 2024

Conversation

Pablete1234
Copy link
Member

Fixes:

  • Force-applying potion effects with duration=0 in modern does nothing, as they can stack without one overriding the other
  • Infinite duration potion effects were using large numbers, when in modern you can just use -1 for "infinite"

@Pablete1234 Pablete1234 mentioned this pull request Nov 25, 2024
Open
8 tasks
@Pablete1234 Pablete1234 merged commit 59079bb into dev Nov 25, 2024
2 checks passed
@Pablete1234 Pablete1234 deleted the fix-remove-potion-kit branch November 25, 2024 22:29
Pablete1234 added a commit that referenced this pull request Nov 30, 2024
@Pablete1234
Add potion effect improvements for modern (#1441)
04af9f1 
Signed-off-by: Pablo Herrera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswhite2000 cswhite2000 cswhite2000 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pablete1234 @cswhite2000