Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make assists part of stats #1469

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Make assists part of stats #1469

merged 2 commits into from
Dec 31, 2024

Conversation

Pablete1234
Copy link
Member

@Pablete1234 Pablete1234 commented Dec 31, 2024

Supercedes #1467 , makes it so assists are fully integrated into pgm, showing on match end stats, tablist, etc

Adding assists made certain things not work out as well as they used to (eg: "Your stats: " line) so they were modified and enhanded, here's how it looks:

image

image

  • Multiple players can be shown for a stat now
  • If over 3 players have a stat, it instead goes to "several Players" with a hover
  • If over 10 players have a stat, it will just show "many, many players" and no hover (no point in showing the 20 ppl who all got 1 death in blitz)
  • Instead of showing "Your stats", they show as "(You: x)"
  • "You" is omitted if you're in the list of top players for that stat
  • If a stat max is 0 , it is no longer displayed at match end

Signed-off-by: Pablo Herrera <[email protected]>
Signed-off-by: Pablo Herrera <[email protected]>
@Pablete1234 Pablete1234 merged commit df8e82e into dev Dec 31, 2024
2 checks passed
@Pablete1234 Pablete1234 deleted the adopt-assists branch December 31, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants