Add ScoreCause to CompetitorScoreChangeEvent and MatchPlayerScoreEvent #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: OhPointFive <[email protected]>
Pablete1234
reviewed
Feb 2, 2025
Signed-off-by: OhPointFive <[email protected]>
OhPointFive
force-pushed
the
add-score-causes
branch
from
7ef11e0 to
710b8cf
Compare
Signed-off-by: OhPointFive <[email protected]>
Pablete1234
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Score Causes
This PR adds a
ScoreCauseto the eventsCompetitorScoreChangeEventandMatchPlayerScoreEvent.Possible
ScoreCauses are:CONTROL_POINTDEATHFLAG_CAPTUREFLAG_TICKKILLSCOREBOXVARIABLEMotivation
In our original use case, I need a way to know when a player has gone into a scorebox, and for how many points they scored. A reasonable alternative to this would be to add an event for when a player enters a scorebox.
This approach seems more generally useful, though, and could be used for making an interactive graph of the match score, for example.