Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing filters info and corrected info on some modules #103

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

TheRealPear
Copy link
Contributor

This pull request adds some missing information concerning the pulse, countdown, after, and players filter. Additionally, I corrected some information regarding Ender chests and relabeled the values for some items (formatted message instead of strings, etc.) and some editorial changes.

@TheRealPear TheRealPear marked this pull request as draft August 19, 2023 14:50
@TheRealPear TheRealPear marked this pull request as ready for review September 16, 2023 19:16
@TheRealPear TheRealPear force-pushed the correction branch 2 times, most recently from 17812b6 to d5bf659 Compare September 25, 2023 02:22
@TheRealPear
Copy link
Contributor Author

Just a last minute change here, I have no idea how soon this will be reviewed. I've updated Fandom links, once again, to the new Minecraft wiki (https://minecraft.wiki/), which will be the new home for Minecraft information moving forward, with less obstructive ads and better experience for visitors.

I've rebased and unified the existing commits into one for easier reviewing. Let me know if there is anything that needs correcting

Reorganize enderchest (writing is hard)
Corrected enderchest dropoff
Rewrite dropoff filter description (credits to Pablo for proofreading)
Change Fandom links to new MC Wiki
Reworded dropoff trigger sentence

Signed-off-by: TheRealPear <[email protected]>
@CoWinkKeyDinkInc
Copy link
Collaborator

Thanks for changing the wiki links.

@CoWinkKeyDinkInc CoWinkKeyDinkInc merged commit f863c53 into PGMDev:master Sep 30, 2023
3 checks passed
@TheRealPear TheRealPear deleted the correction branch October 1, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants