Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document tracking compass modules & more #123

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

TheRealPear
Copy link
Contributor

Part two of the big branch.

Commands

  • Disabled unused table of content sidebar for all three command pages to give the table more room, especially on larger screens
  • Added filter to PGM command, resolves Document Filter Command #97
  • Split /pgm into more commands

Main Map Element

Broadcast

  • Retyped a duplicated table row (how could you tell I copied and pasted these a while ago?)

Actions

Tracking Compass
I've made a new page covering this. I've sourced information from PGMDev/PGM#1308 and PGMDev/PGM#1333.

As usual, I appreciate any feedback and correction

@TheRealPear
Copy link
Contributor Author

Consumables

  • Removed kit alias from action attribute in the table and example.
  • Documented click consumables from Implement click consumables PGM#1348. This includes the override-consume behavior table with some explanation.

@TheRealPear
Copy link
Contributor Author

Damage

@TheRealPear
Copy link
Contributor Author

Actions & Triggers

Variables

Added some mentions (variable) expressions/formulas, but I've yet to write a section on covering them due to lack of information and knowledge on my part. I've also skipped on examples, which I will plan on adding in the future

Lastly, this is the most important update so far in the pull request. I recommend reviewing for any inaccuracy @Pablete1234

@TheRealPear
Copy link
Contributor Author

Actions & Trigger

Main

Scoring

  • Add a N/A tag to box trigger attribute since it hasn't been re-implemented.

@TheRealPear
Copy link
Contributor Author

Terrain

  • Removed docs.oc.tc leftover
  • Documented environment attribute under terrain table
  • Add a N/A tag to pre-match-physics since it hasn't been re-implemented

Copy link
Collaborator

@CoWinkKeyDinkInc CoWinkKeyDinkInc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This draft is changing many different things. I think it's time to focus on merging this one and adding additional stuff to another PR

@TheRealPear TheRealPear marked this pull request as ready for review July 19, 2024 16:41
@CoWinkKeyDinkInc CoWinkKeyDinkInc merged commit 8ee0874 into PGMDev:master Jul 23, 2024
3 checks passed
@TheRealPear TheRealPear deleted the 2024-06-21 branch July 25, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Document Filter Command
4 participants