Test enhancement about some PHPUnit stuffs #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeseekr
requested changes
Aug 4, 2020
tests/DataTypeValidatorTest.php
Outdated
| @@ -144,7 +144,7 @@ public function testDataCannotBeNullByDefault() | |||
| 'name' => 'string', | |||
| ]; | |||
|
|
|||
| self::expectException(InvalidDataTypeException::class); | |||
| $this->expectException(InvalidDataTypeException::class); | |||
There was a problem hiding this comment.
This needs to be reverted back to self:: for self-sufficiency.
There was a problem hiding this comment.
Actually, it should be $this to call expectException method.
And it only has the two method call about assertion methods.
Some references are available here:
- https://phpunit.readthedocs.io/en/8.5/assertions.html?highlight=assertion#static-vs-non-static-usage-of-assertion-methods
- https://phpunit.readthedocs.io/en/8.5/writing-tests-for-phpunit.html#testing-exceptions
But I think it's fine to use self to call expectException method, too.
I will revert this :).
There was a problem hiding this comment.
Hi @hopeseekr, thanks for your comment.
And I've reverted this about using the self to do expectException method call :).
peter279k
force-pushed
the
test_enhancement
branch
from
06c16d0 to
ec025c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
php-7.4version test during Travis CI build.carbondate/carbonpackage is abandoned/deprecated. Using thenesbot/carbonpackage instead.selfapproach to make PHPUnit assertion call.$thisapproach to makeexpectExceptionmethod call.classmap-authoritativeconfig insidecomposer.jsonfile.protected function setUp(): voidmethod.This change is