Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change - 3 Defaults #4340

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Feb 4, 2025

Fix #4092. Change default value for Csv Reader autodetect line endings. Prior behavior can be enabled via setTestAutodetect(true).

Change default value for Html Writer "better boolean" logic. Prior behavior can be explicitly enabled via setBetterBoolean(false).

Change default for Xlsx Writer forceFullCalc option. Prior behavior can be explicitly enabled via setForceFullCalc(null).

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • more sensible default values

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Fix PHPOffice#4092. Change default value for Csv Reader autodetect line endings. Prior behavior can be enabled via `setTestAutodetect(true)`.

Change default value for Html Writer "better boolean" logic. Prior behavior can be explicitly enabled via `setBetterBoolean(false)`.

Change default for Xlsx Writer forceFullCalc option. Prior behavior can be explicitly enabled via `setForceFullCalc(null)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

$reader->setTestAutodetect() not usefull when php version > 8.1
1 participant