Make handle_transaction explicitly return the new decrypted notes #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panleone
force-pushed
the
handle_block_performance
branch
from
ac98f47 to
db303dc
Compare
Merged
Duddino
reviewed
Oct 25, 2024
src/transaction.rs
Outdated
| witness | ||
| .write(&mut buff) | ||
| .map_err(|_| "Cannot write witness to buffer")?; | ||
| ser_comp_note.push((note.clone(), hex::encode(&buff))); |
panleone
force-pushed
the
handle_block_performance
branch
from
db303dc to
2410f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the output of
handle_transactionin two vectors of notesdecryptedNotes;This is a nice optimization because now we can directly calculate the nullifier ONLY for the new notes. (Before this PR each transaction was handled twice, while in #89 nullifiers are recomputed for each note at each block)