Deterministic Masternodes GUI + Bug Fixes #2791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decoupling the RPC server errors from the function.
And use the `PROTOCOL_VERSION` instead of the `CLIENT_VERSION`. Which should had never been used there as the serialization of inputs/spend_notes cannot be modified changing the `CLIENT_VERSION`, it's a hard-fork that needs a protocol bump.
Same validation is performed inside TryATMP.
…the network. The transaction inputs are always from the wallet.
And remove duplicated available inputs validation. The code will perform the same check few lines after the signature inside ATMP.
Differentiating deterministic from legacy masternodes
…created locally). Only useful when the owner generates the operator key, so the object can be securely stored inside the wallet.dat encrypted. A future work could create an encryptable db for this specific object.
…qual to the previous type
co-authored with random.zebra <[email protected]>
Liquid369
force-pushed
the
2023_regtest_fix
branch
from
391ef93 to
daa8680
Compare
Liquid369
force-pushed
the
2023_regtest_fix
branch
from
f5278bd to
6dd881a
Compare
|
Superseding PR #2804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored with @panleone
Trying to follow up on work with Deterministic Masternodes, this was taken from furszy's repo and has been running regtest.
We found a few issues along the way trying to carry forward the current work, this PR will essentially supersede PR#2751 as it has the DMN GUI already and we are carrying forward the testing process.
This PR fixes two bugs we found in regard to Creating Masternodes with a Single Input, alongside allowing said input into mempool and causing the chain to stall.
Upcoming work to still do:
We will update the list accordingly as we assess more work and features/functionality