Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] speed un tiertwo_governance_sync_basic #2916

Merged

Conversation

panleone
Copy link

tiertwo_governance_sync_basic is by far the slowest test that we have. Profiling showed that most of the time was spent in the function stake() which slept for a total of 2 seconds in each call.

Those 2 seconds sleep were actually useless and have been removed.
With this simple change the total running time of the test on my machine dropped from 15 minutes to only 6 minutes.

To prove that indeed sleeping was useless I tried to run the same test in parallel 15 times, and it never failed, see here:
https://github.com/panleone/PIVX/actions/runs/8420343441

@panleone panleone self-assigned this Mar 25, 2024
@panleone panleone added the Tests label Mar 25, 2024
@panleone panleone added this to the 6.0.0 milestone Mar 25, 2024
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to pass without sleeping
utACK 471cae3

Copy link
Member

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 471cae3

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 471cae3

@Fuzzbawls Fuzzbawls merged commit e4f61cd into PIVX-Project:master Apr 2, 2024
21 checks passed
@panleone panleone deleted the fast_functional_tests_attempt_3 branch April 2, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants