[LLMQ] Improve thread handling #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rThread twice Squash where I add interrupt
Duddino
approved these changes
Mar 26, 2024
Liquid369
approved these changes
Mar 27, 2024
Fuzzbawls
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues in the LLMQ threads handling, that might be also causing some problems in some tests that randomly fail during the final
ShutDown()phase.First 3 commits are just trivial refactor:
Use unique pointers in place of normal pointers to be consistent with the style used for other llmq managers.
Fourth commit:
In
CSigSharesManagerthe functionStopWorkerThread()was being called twice. The wrong call was the one in the destructor which has been removed.The rest of the diff is basically a copy and paste from net_masternodes.cpp (the variable
interruptNetof that file plays the exact same role of the variableinterruptSigningSharethat I have added).This new version should be the right way to manage the thread
Fifth commit:
In the chainlock manager split the
Initfrom theStartand theStopfrom theDestroyphases, as we do for all other llmq managers.