[Cleanup] Declare single-argument (non-converting) constructors "explicit" #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panleone
previously approved these changes
Nov 2, 2024
Duddino
previously approved these changes
Nov 5, 2024
Liquid369
previously approved these changes
Nov 7, 2024
Fuzzbawls
force-pushed
the
2024_explicit-constructors
branch
from
18a9d6c to
bf8fef9
Compare
Fuzzbawls
force-pushed
the
2024_explicit-constructors
branch
from
bf8fef9 to
1cc9a80
Compare
|
Rebased on master to resolve conflicts |
panleone
approved these changes
Nov 13, 2024
Liquid369
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare single-argument (non-converting) constructors
explicit.In order to avoid unintended implicit conversions.
Coming from bitcoin#10969
Added a new CI lint job that uses
cppcheckto indicate any regressions or new introductions. This lint framework can be expanded on to catch other static analysis warnings in future PRs.