Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDS-155/fix] 월별 장비/차량 예약 불가능 날짜 조회 로직 수정 #265

Merged
merged 3 commits into from
Dec 1, 2023
Merged

[PDS-155/fix] 월별 장비/차량 예약 불가능 날짜 조회 로직 수정 #265

merged 3 commits into from
Dec 1, 2023

Conversation

sojungpp
Copy link
Member

@sojungpp sojungpp commented Nov 30, 2023 •
edited
Loading

✈️ 지라 티켓

  • PDS-155 월별 장비/차량 예약 불가능 날짜 조회 로직 수정

👾 작업 내용

  • 예약 현황 조회 로직 수정
  • Map<LocalDate, Integer> 바탕으로 해당 날짜의 시간이 예약될 때마다 +1 -> 24시간 모두 예약된 날짜 반환
    (아이디어 감사링- @psyeon1120 @chaerlo127 )
  • 예약 관련 조회 시, 예약 완료된 것까지 고려하도록 변경

📸 스크린샷


🎸 기타 사항

예약시작시간 예약종료시간
11.30 17 12.02 02
12.12 00 12.15 15
12.15 13 12.15 15
12.15 15 12.16 03
12.16 03 12.17 00
12.17 05 12.19 01

-> 이 케이스 테스트 완 하하

@sojungpp sojungpp added the ⛑️ Fix 버그 코드를 수정해요 ! label Nov 30, 2023
@sojungpp sojungpp self-assigned this Nov 30, 2023
@sojungpp sojungpp requested a review from a team as a code owner November 30, 2023 18:30
@sojungpp sojungpp requested review from psyeon1120, dangnak2, leeseunghakhello and chaerlo127 and removed request for a team November 30, 2023 18:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

leeseunghakhello
leeseunghakhello reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@leeseunghakhello leeseunghakhello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 로직은 볼때마다 머리 아프네요.. 고생!

chaerlo127
chaerlo127 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@chaerlo127 chaerlo127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인간승리👏👏

@chaerlo127 chaerlo127 merged commit 904c535 into develop Dec 1, 2023
2 checks passed
@chaerlo127 chaerlo127 deleted the fix/PDS-155-getResourceBookedDate branch December 1, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeseunghakhello leeseunghakhello leeseunghakhello approved these changes

@chaerlo127 chaerlo127 chaerlo127 approved these changes

@psyeon1120 psyeon1120 Awaiting requested review from psyeon1120 psyeon1120 is a code owner automatically assigned from PLADI-ALM/server-team

@dangnak2 dangnak2 Awaiting requested review from dangnak2 dangnak2 is a code owner automatically assigned from PLADI-ALM/server-team

Assignees

@sojungpp sojungpp

Labels
⛑️ Fix 버그 코드를 수정해요 !
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sojungpp @leeseunghakhello @chaerlo127