-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update file calls in calibration modules #112
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 75.49% 73.29% -2.21%
==========================================
Files 11 11
Lines 857 865 +8
==========================================
- Hits 647 634 -13
- Misses 210 231 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@jdebacker. Here is the output of running all the tests locally on my machine.
|
@jdebacker. I merged your PR to my branch. This PR is now ready for final review. |
CHANGELOG.md
Outdated
|
||
### Added | ||
|
||
- Updates the file calls in some of the calibration modules (`bequest_transmission.py`, `deterministic_profiles.py`, `psid_data_setup.py`, and `transfer_distirbution.py`). These files called `.RData` files that were not included in the `ogusa` package, so users who pip installed ogusa could not instantiate the `Calibrate` class object. These changes allow for Jupyter notebook users to automatically download the data files from the master branch of the GitHub repository if they are not working in their own branch of the repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rickecon I think we should update this. Perhaps:
Updates the `ogusa` package to include the zipped `psid_lifetime_income.csv.gz` file, which is now called in some calibration modules (`bequest_transmission.py`, `deterministic_profiles.py`, and `transfer_distirbution.py`), but with an option for the user to provide their own custom datafile. These changes allow for Jupyter notebook users to execute the `Calibration` class object and for those who install the `ogusa` package from PyPI to have the required datafile for the major calibration modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdebacker. I just made this change.
thank you @rickecon! Merging. |
This PR:
bequest_transmission.py
,deterministic_profiles.py
,psid_data_setup.py
, andtransfer_distirbution.py
). These files called.RData
files that were not included in theogusa
package, so users who pip installed ogusa could not instantiate theCalibrate
class object. These changes allow for Jupyter notebook users to automatically download the data files from the master branch of the GitHub repository if they are not working in their own branch of the repository.I ran all the tests on my local machine and they all passed. And I verified that I could run a modified
run_og_usa.py
run script from a Jupyter notebook that was not in the branch structures of my OG-USA repository.cc: @jdebacker