Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rpy2 dependency #115

Merged
merged 16 commits into from
Jun 11, 2024
Merged

Remove rpy2 dependency #115

merged 16 commits into from
Jun 11, 2024

Conversation

jdebacker
Copy link
Member

This PR removes the rpy2 dependency by replacing the .RData files with zipped CSV files.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.51%. Comparing base (e994433) to head (d7ee0fb).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #115       +/-   ##
===========================================
- Coverage   73.15%   46.51%   -26.65%     
===========================================
  Files          11       17        +6     
  Lines         868     1363      +495     
===========================================
- Hits          635      634        -1     
- Misses        233      729      +496     
Flag Coverage Δ
unittests 46.51% <100.00%> (-26.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogusa/__init__.py 100.00% <100.00%> (ø)
ogusa/psid_data_setup.py 98.78% <100.00%> (-0.08%) ⬇️

... and 5 files with indirect coverage changes

@jdebacker jdebacker requested a review from rickecon June 11, 2024 02:23
@jdebacker jdebacker marked this pull request as ready for review June 11, 2024 02:23
@jdebacker
Copy link
Member Author

@rickecon This PR is ready for review.

@rickecon
Copy link
Member

@jdebacker. This PR is ready to merge. I restarted the CI and saw all the tests pass. I committed one change to the CHANGELOG.md file, which made all the tests re-run. I will merge this PR as soon as all the test run again. But I saw the Windows tests work. This PR successfully puts the Windows tests back in. Nice fix.

@rickecon rickecon linked an issue Jun 11, 2024 that may be closed by this pull request
@rickecon rickecon merged commit acb734c into PSLmodels:master Jun 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows GH Action tests not running
3 participants