-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to environment.yml and macro_params.py #89
Conversation
@jdebacker. I am trying out adding back the Windows tests in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
=======================================
Coverage 70.82% 70.82%
=======================================
Files 22 22
Lines 1340 1340
=======================================
Hits 949 949
Misses 391 391
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jdebacker. This PR is ready for your review. |
LGTM - thanks @rickecon! Merging. |
This PR:
environment.yml
andsetup.py
to be <3.12_config.yml
macro_params.py
to be "QE" instead of just "Q"README.md
andintro.md
build_and_test.yml
This PR includes the change suggested by @talumbau in PR #82. However, that PR was running too many tests and was having black formatting issues. So I have closed that PR and added its changes to this PR.
cc: @jdebacker