Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to environment.yml and macro_params.py #89

Merged
merged 10 commits into from
Feb 12, 2024

Conversation

rickecon
Copy link
Member

@rickecon rickecon commented Feb 12, 2024

This PR:

  • Restricts Python version in environment.yml and setup.py to be <3.12
  • Updates the Jupyter Book copyright to 2024 in _config.yml
  • Updates the pandas_datareader quarterly calls in macro_params.py to be "QE" instead of just "Q"
  • Adds Jupyter Book and Black tags to README.md and intro.md
  • Adds back Windows tests to build_and_test.yml

This PR includes the change suggested by @talumbau in PR #82. However, that PR was running too many tests and was having black formatting issues. So I have closed that PR and added its changes to this PR.

cc: @jdebacker

@rickecon
Copy link
Member Author

@jdebacker. I am trying out adding back the Windows tests in build_and_test.yml in this PR to see if the problem in Issue #78. If these tests continue to fail or get stuck in the GH Action, I will pull them out.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a6757b) 70.82% compared to head (cef2e94) 70.82%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   70.82%   70.82%           
=======================================
  Files          22       22           
  Lines        1340     1340           
=======================================
  Hits          949      949           
  Misses        391      391           
Flag Coverage Δ
unittests 70.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickecon
Copy link
Member Author

@jdebacker. This PR is ready for your review.

@jdebacker
Copy link
Member

LGTM - thanks @rickecon! Merging.

@jdebacker jdebacker merged commit e7b564b into PSLmodels:master Feb 12, 2024
6 checks passed
@rickecon rickecon deleted the upds branch February 12, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants