Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better hit sound feedback #176

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

kai-li-wop
Copy link
Member

@kai-li-wop kai-li-wop commented Aug 2, 2022

This should offer better hit sound feedback inspired by Q3 Team Arena.

  • when opponent has >50 shield points, a more light hit sound indicating less impact is played
  • when opponent has no shield points left, a more fleshy hit sound indicating highest impact is played (fleshy sound is the former friendly fire hit sound)
  • for everything else the known default hit sound is played
  • adds new cvar cg_advHitSounds [0/1] to enable/disable this feature, default is 0 (off)
  • adds a new menu entry in options/game to enable/disable this feature via the menu
  • adds a new beep hit sound to indicate friendly fire at teammates when the server has friendly fire enabled

ToDo:

  • Apply Q3 Team Arena code (see cg_playerstate.c, search for hit changes comment)
  • Add new hit sound sample for shield
  • Add new hit sound sample for friendly fire
  • Use more "fleshy" (former) friendly fire hit sound sample to indicate no shield
  • Add new CVAR "cg_advHitSound" [0|1] to disable/enable the feature
  • Add a switch to the game options menu

This should offer better hit sound feedback inspired by Q3 Team Arena.

- when opponent has >50 shield points, a more light hit sound indicating less impact is played
- when opponent has no shield points left, a more fleshy hit sound indicating highest impact is played (fleshy sound is the former friendly fire hit sound)
- for everything else the known default hit sound is played
- adds new cvar cg_advHitSounds [0/1] to enable/disable this feature, default is 0 (off)
- adds a new menu entry in options/game to enable/disable this feature via the menu
- adds a new beep hit sound to indicate friendly fire at teammates when the server has friendly fire enabled
@kai-li-wop kai-li-wop marked this pull request as ready for review November 8, 2023 09:51
@kai-li-wop kai-li-wop merged commit 35155e8 into PadWorld-Entertainment:main Nov 8, 2023
5 of 6 checks passed
@kai-li-wop kai-li-wop deleted the hitfeedback branch November 8, 2023 10:03
@3aTmE
Copy link

3aTmE commented Nov 15, 2023

Just tried this feature for myself! It seems to be working just fine.
The sounds are too way too quiet tho.

I tried to adjust this for myself by editing the Sounds but just ended up with screeching white noise.
But at least the horrible noises that I've created changed accordingly to what they are meant to represent :)

In short : it works, it's quiet, but it works.
And never ever boost random sounds 15 Decibels when you value your eardrums.

@kai-li-wop
Copy link
Member Author

@3aTmE: I did not experience them as too quiet. I used the original sound files from the game. I pitched the default hit sound a little higher and used it as sound for 50+ shield. The fleshy sound is the original hit team sound. No changes in volume made. The new hit team beep should be loud enough, but I will test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants