-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GENDER: Enable the user to select the gender #199
Conversation
This is part of pr #199 and is handled differently there.
a237508
to
45b548b
Compare
725556d
to
65cfc3d
Compare
96a9211
to
e98e447
Compare
- inspired by PadWorld-Entertainment/worldofpadman-fork#41 - add "none" as a new gender which will force "they/them" to be used instead of e.g. "male" with "he/him" - add "model" as the new default gender which will force always to apply the gender of the selected player model (to keep old behavior) - also "none" is the fallback for a model if a gender is undefined in animations.cfg - add gender neutral event messages - fix minor typos in event messages - add gender selection option (model/male/female/neuter/none) in player settings menu; if "model" the gender is normally set by the player model via animations.cfg, else taken from user info "sex" - add a tool tip for gender selection option
@mgerhardy: There is still an issue when switching back from any selected gender to the model's gender in player settings menu. The shown chat prints they/them from the none gender instead of the selected model's gender until the player manually selects another model. Same when the map changes, the model's gender is always gender_none until the user selects a new model manually. |
Just tested this Feature and can confirm that it just works like it is supposed to. What was tested?
Jeah, that's all pretty much! |
@3aTmE: Please can you test the issue in my last comment above? When I do like described there is always they/them in the status messages. Can you confirm this? |
Sort of.. When i am using the "none" option all chat prints of the bots are also using they / them pronouns. Even after changing my player model the they / them pronouns of the Bot chat persists. Okay, after i changed the Map the bots are still using they / them pronouns. For me as a player they worked so far flawlessly. |
Ok, referenced this in an extra issue. |
This reverses the gender PR and issues that came with it, since we lack the time to fix them. But we keep some fixes that came with the PR. This also fixes then #222.
Inspired by PadWorld-Entertainment/worldofpadman-fork#41