Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GENDER: Enable the user to select the gender #199

Merged
merged 1 commit into from
Nov 9, 2023
Merged

GENDER: Enable the user to select the gender #199

merged 1 commit into from
Nov 9, 2023

Conversation

kai-li-wop
Copy link
Member

@kai-li-wop kai-li-wop commented Apr 25, 2023

Inspired by PadWorld-Entertainment/worldofpadman-fork#41

  • add "none" as a new gender which will force "they/them" to be used instead of "male" with "he/him"
  • add "model" as the new default gender which will force always to apply the gender of the selected player model (to keep old behavior)
  • also "none" is the fallback for a model if a gender is undefined in animations.cfg
  • add gender neutral event messages
  • fix minor typos in event messages
  • add gender selection option (model/male/female/neuter/none) in player settings menu; if "model" the gender is normally set by the player model via animations.cfg, else taken from user info "sex"
  • add a tool tip for gender selection option

@kai-li-wop kai-li-wop added the enhancement New feature or request label Apr 25, 2023
@kai-li-wop kai-li-wop added this to the v1.7.0 milestone Apr 25, 2023
@kai-li-wop kai-li-wop requested a review from mgerhardy April 25, 2023 08:14
@kai-li-wop kai-li-wop self-assigned this Apr 25, 2023
@kai-li-wop kai-li-wop added the help wanted Extra attention is needed label Sep 5, 2023
kai-li-wop added a commit that referenced this pull request Sep 5, 2023
This is part of pr #199 and is handled differently there.
@kai-li-wop kai-li-wop force-pushed the gender branch 2 times, most recently from a237508 to 45b548b Compare September 8, 2023 14:25
@kai-li-wop kai-li-wop requested review from mgerhardy and removed request for mgerhardy September 11, 2023 11:32
@kai-li-wop kai-li-wop force-pushed the gender branch 3 times, most recently from 725556d to 65cfc3d Compare October 30, 2023 15:58
@kai-li-wop kai-li-wop changed the title GENDER: Enable the user to ignore the gender of all players GENDER: Enable the user to select the gender Oct 30, 2023
@kai-li-wop kai-li-wop force-pushed the gender branch 2 times, most recently from 96a9211 to e98e447 Compare November 1, 2023 09:56
- inspired by PadWorld-Entertainment/worldofpadman-fork#41
- add "none" as a new gender which will force "they/them" to be used instead of e.g. "male" with "he/him"
- add "model" as the new default gender which will force always to apply the gender of the selected player model (to keep old behavior)
- also "none" is the fallback for a model if a gender is undefined in animations.cfg
- add gender neutral event messages
- fix minor typos in event messages
- add gender selection option (model/male/female/neuter/none) in player settings menu; if "model" the gender is normally set by the player model via animations.cfg, else taken from user info "sex"
- add a tool tip for gender selection option
@kai-li-wop kai-li-wop merged commit c03ce4f into main Nov 9, 2023
10 of 12 checks passed
@kai-li-wop
Copy link
Member Author

kai-li-wop commented Nov 9, 2023

@mgerhardy: There is still an issue when switching back from any selected gender to the model's gender in player settings menu. The shown chat prints they/them from the none gender instead of the selected model's gender until the player manually selects another model. Same when the map changes, the model's gender is always gender_none until the user selects a new model manually.

@kai-li-wop kai-li-wop deleted the gender branch November 10, 2023 10:45
@3aTmE
Copy link

3aTmE commented Nov 15, 2023

Just tested this Feature and can confirm that it just works like it is supposed to.

What was tested?

  • Changing the the Sex in the Player menu from Male -> Female -> Neuter and lastly None to check if all chat prints are using the right pronouns.
  • Changing the Sex in the Player menu to Model and switching through different Models to check if all prints are using the right pronouns defied by the Player Model.

Jeah, that's all pretty much!
Works great!

@kai-li-wop
Copy link
Member Author

@3aTmE: Please can you test the issue in my last comment above? When I do like described there is always they/them in the status messages. Can you confirm this?

@kai-li-wop kai-li-wop removed the help wanted Extra attention is needed label Nov 15, 2023
@3aTmE
Copy link

3aTmE commented Nov 15, 2023

@3aTmE: Please can you test the issue in my last comment above? When I do like described there is always they/them in the status messages. Can you confirm this?

Sort of.. When i am using the "none" option all chat prints of the bots are also using they / them pronouns.
After changing to any other Sex option the they / them pronouns of the Bot chat stays. No matter what other options i use.

Even after changing my player model the they / them pronouns of the Bot chat persists.

Okay, after i changed the Map the bots are still using they / them pronouns.

For me as a player they worked so far flawlessly.

@kai-li-wop
Copy link
Member Author

Ok, referenced this in an extra issue.

kai-li-wop added a commit that referenced this pull request Jun 30, 2024
This reverses the gender PR and issues that came with it, since we lack the time to fix them. But we keep some fixes that came with the PR. This also fixes then #222.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants