Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCORD: added discord support for servers via webhook #214

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

mgerhardy
Copy link
Member

@mgerhardy mgerhardy commented Oct 26, 2023

this allows us to publish messages from a game server to discord if the cvar discord_webhook_url is set properly

a new automated tests framework was added, too

the discord requests are made with a more general http request interface and could get used for other stuff, too (e.g. mod.io).

@kai-li-wop kai-li-wop added the enhancement New feature or request label Oct 28, 2023
@kai-li-wop kai-li-wop added this to the v1.7.0 milestone Oct 28, 2023
@mgerhardy mgerhardy force-pushed the pr/discord branch 3 times, most recently from 2c5d1bf to 77edf36 Compare October 28, 2023 19:07
@mgerhardy mgerhardy force-pushed the pr/discord branch 2 times, most recently from d4ca719 to 93f8f0a Compare October 28, 2023 19:51
this allows us to publish messages to discord if the cvar discord_webhook_url is set properly

this can be done async or sync

currently only a message is sent when a new user connects to the server - and on map finish
but maybe we want other messages to be sent on frags or round ends with the winner

some performance checks should maybe also be done with the easy interface of curl vs the
multi interface of curl for the async requests

a new automated tests framework was added, too

the discord requests are made with a more general http request interface and could get used
for other stuff, too.
@mgerhardy mgerhardy changed the title DISCORD: added discord support DISCORD: added discord support for servers Oct 29, 2023
@mgerhardy mgerhardy changed the title DISCORD: added discord support for servers DISCORD: added discord support for servers via webhook Oct 29, 2023
@mgerhardy mgerhardy force-pushed the pr/discord branch 2 times, most recently from 575ffb6 to 9160d8a Compare October 31, 2023 17:54
@mgerhardy mgerhardy merged commit 781404f into main Oct 31, 2023
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants