add crop_tensor_op #19314

zhangting2020 · 2019-08-20T16:43:33Z

add crop_tensor op. The main difference with crop is :

If the argument shape is a list, each element is an integer or a tensor variable with shape: [1]. This way is suitable for the case that the shape may be changed each iteration.
If the argument shape is a variable. Its rank must be 1. In crop op, the rank of shape must be the same as x
offsets can be a list, in which each element is an integer or a tensor variavle with shape: [1].

zhangting2020 · 2019-08-21T02:39:18Z

document preview

modified the doc of crop:
add the doc of crop_tensor:

heavengate

Please add python API test in test_layers.py

heavengate · 2019-08-30T02:04:14Z

paddle/fluid/operators/crop_tensor_op.cc

@@ -0,0 +1,269 @@
+/* Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.


2018 -> 2019

Done.

add python API test in test_layers.py

modified Copyright (c) 2018 to Copyright (c) 2019 of 4 files: crop_tensor_op.cc、crop_tensor_op.cu、crop_tensor_op.h、test_crop_tensor_op.py

lanxianghit · 2019-08-30T07:54:35Z

paddle/fluid/operators/crop_tensor_op.cc

+  using framework::OperatorWithKernel::OperatorWithKernel;
+
+  void InferShape(framework::InferShapeContext *ctx) const override {
+    PADDLE_ENFORCE(ctx->HasInput("X"),


PADDLE_ENFORCE都需要改为其他接口，PADDLE_ENFORCE_GT等

lanxianghit · 2019-08-30T08:51:41Z

python/paddle/fluid/layers/nn.py

+                assert unk_dim_idx == -1, (
+                    "Only one element in shape can be unknown.")
+                assert dim_idx == 0, (
+                    "Only the first element in shape can be -1.")


为什么限制只能是第一个元素？

第一维是batch size，可以感觉输入得到。在其他维度如果出现-1，crop_tensor操作并不能根据已知的维度推断这个-1所在的维度应该是多少。原有的crop同样不支持第一维之外的其他维度为-1。

我们的batch size 一定要第一维么。。还是这个op就有这种要求

目前保持原始crop的逻辑。-1的意义已和佳军沟通，进一步确认需求后再进行修改。本次PR只修改参数支持tensor

phlrain · 2019-09-02T03:22:20Z

python/paddle/fluid/layers/nn.py

@@ -8971,6 +8975,152 @@ def crop(x, shape=None, offsets=None, name=None):
    return out


+def crop_tensor(x, shape=None, offsets=None, name=None):


新接口就叫做crop_tensor么

phlrain · 2019-09-02T03:25:01Z

python/paddle/fluid/layers/nn.py

+            element of list can be a integer or a tensor Variable with shape: [1].
+            This way is suitable for the case that the shape may be changed each 
+            iteration.
+        offsets (Variable|list/tuple of integer|None): Specifies the cropping


offset 不可以为 list(Variable)么

修改后已支持offset为list(Variable)

phlrain · 2019-09-02T03:28:47Z

python/paddle/fluid/layers/nn.py

+                assert unk_dim_idx == -1, (
+                    "Only one element in shape can be unknown.")
+                assert dim_idx == 0, (
+                    "Only the first element in shape can be -1.")


我们的batch size 一定要第一维么。。还是这个op就有这种要求

phlrain · 2019-09-02T03:31:46Z

python/paddle/fluid/layers/nn.py

+
+    .. code-block:: text
+
+        * Case 1:


是不是可以给一个3D的例子

这个op的应用场景主要是图像领域，batch size通常在第一维

在文档中添加了3-D的例子

jiangjiajun · 2019-09-02T10:58:49Z

测试了Python接口，offsets使用存在一些问题，已反馈。

zhangting2020 · 2019-09-05T02:17:11Z

测试了Python接口，offsets使用存在一些问题，已反馈。

已增加offset支持list(variable)

phlrain

LGTM

lanxianghit

LGTM

raindrops2sea

LGTM

lanxianghit

LGTM

raindrops2sea

LGTM

…#19314) add crop_tensor op. The main difference with crop is : 1. If the argument shape is a list, each element is an integer or a tensor variable with shape: [1]. This way is suitable for the case that the shape may be changed each iteration. 2. If the argument shape is a variable. Its rank must be 1. In crop op, the rank of shape must be the same as x offsets can be a list, in which each element is an integer or a tensor variavle with shape: [1].

zhangting2020 force-pushed the crop_tensor branch from 773fb42 to 5ee3da9 Compare August 21, 2019 12:12

heavengate reviewed Aug 30, 2019

View reviewed changes

zhangting2020 force-pushed the crop_tensor branch 3 times, most recently from b39085c to 5bc8cf2 Compare August 30, 2019 05:55

heavengate previously approved these changes Aug 30, 2019

View reviewed changes

lanxianghit reviewed Aug 30, 2019

View reviewed changes

zhangting2020 dismissed heavengate’s stale review via 929c52c August 30, 2019 09:28

zhangting2020 force-pushed the crop_tensor branch 2 times, most recently from 929c52c to 97b8bcd Compare August 30, 2019 09:37

lanxianghit previously approved these changes Aug 30, 2019

View reviewed changes

phlrain reviewed Sep 2, 2019

View reviewed changes

zhangting2020 dismissed lanxianghit’s stale review via ac1a46d September 4, 2019 08:16

zhangting2020 force-pushed the crop_tensor branch 2 times, most recently from ac1a46d to e420249 Compare September 4, 2019 13:28

phlrain previously approved these changes Sep 9, 2019

View reviewed changes

lanxianghit previously approved these changes Sep 9, 2019

View reviewed changes

heavengate previously approved these changes Sep 11, 2019

View reviewed changes

raindrops2sea previously approved these changes Sep 12, 2019

View reviewed changes

zhangting2020 dismissed stale reviews from raindrops2sea, heavengate, lanxianghit, and phlrain via ff8098d September 15, 2019 12:05

zhangting2020 force-pushed the crop_tensor branch from e420249 to ff8098d Compare September 15, 2019 12:05

heavengate previously approved these changes Sep 16, 2019

View reviewed changes

phlrain self-requested a review September 16, 2019 02:57

phlrain previously approved these changes Sep 16, 2019

View reviewed changes

lanxianghit previously approved these changes Sep 16, 2019

View reviewed changes

zhangting2020 dismissed stale reviews from lanxianghit, phlrain, and heavengate via 7013690 September 16, 2019 07:32

zhangting2020 force-pushed the crop_tensor branch from ff8098d to 7013690 Compare September 16, 2019 07:32

lanxianghit previously approved these changes Sep 17, 2019

View reviewed changes

zhangting2020 dismissed lanxianghit’s stale review via 416b211 September 18, 2019 00:39

zhangting2020 force-pushed the crop_tensor branch from 7013690 to 416b211 Compare September 18, 2019 00:39

add crop_tensor_op, test=develop, test=document_preview

4f09abb

zhangting2020 force-pushed the crop_tensor branch from 416b211 to 4f09abb Compare September 18, 2019 07:45

phlrain self-requested a review September 19, 2019 02:16

phlrain approved these changes Sep 19, 2019

View reviewed changes

heavengate approved these changes Sep 19, 2019

View reviewed changes

lanxianghit approved these changes Sep 19, 2019

View reviewed changes

raindrops2sea approved these changes Sep 19, 2019

View reviewed changes

Aurelius84 merged commit b388894 into PaddlePaddle:develop Sep 20, 2019

zhangting2020 deleted the crop_tensor branch October 21, 2019 09:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add crop_tensor_op #19314

add crop_tensor_op #19314

zhangting2020 commented Aug 20, 2019 •

edited

Loading

zhangting2020 commented Aug 21, 2019 •

edited

Loading

heavengate left a comment

heavengate Aug 30, 2019

zhangting2020 Aug 30, 2019

lanxianghit Aug 30, 2019

zhangting2020 Aug 30, 2019

lanxianghit Aug 30, 2019

zhangting2020 Aug 30, 2019

phlrain Sep 2, 2019

zhangting2020 Sep 9, 2019

phlrain Sep 2, 2019

zhangting2020 Sep 4, 2019

phlrain Sep 2, 2019

zhangting2020 Sep 4, 2019

phlrain Sep 2, 2019

phlrain Sep 2, 2019

zhangting2020 Sep 4, 2019

jiangjiajun commented Sep 2, 2019 •

edited

Loading

zhangting2020 commented Sep 5, 2019

phlrain left a comment

lanxianghit left a comment

raindrops2sea left a comment

lanxianghit left a comment

raindrops2sea left a comment

		@@ -0,0 +1,269 @@
		/* Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.

		@@ -8971,6 +8975,152 @@ def crop(x, shape=None, offsets=None, name=None):
		return out


		def crop_tensor(x, shape=None, offsets=None, name=None):

add crop_tensor_op #19314

add crop_tensor_op #19314

Conversation

zhangting2020 commented Aug 20, 2019 • edited Loading

zhangting2020 commented Aug 21, 2019 • edited Loading

heavengate left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jiangjiajun commented Sep 2, 2019 • edited Loading

zhangting2020 commented Sep 5, 2019

phlrain left a comment

Choose a reason for hiding this comment

lanxianghit left a comment

Choose a reason for hiding this comment

raindrops2sea left a comment

Choose a reason for hiding this comment

lanxianghit left a comment

Choose a reason for hiding this comment

raindrops2sea left a comment

Choose a reason for hiding this comment

zhangting2020 commented Aug 20, 2019 •

edited

Loading

zhangting2020 commented Aug 21, 2019 •

edited

Loading

jiangjiajun commented Sep 2, 2019 •

edited

Loading