Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup][A-7] Replace VarType #61548

Merged
merged 3 commits into from
Feb 4, 2024
Merged

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Feb 4, 2024

PR types

Others

PR changes

Others

Description

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件直接恢复吧,这个暂时不适合修改

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@@ -229,9 +229,9 @@ def test_out_dtype():
shape=[3, 4], dtype='float64'
)
if paddle.framework.in_pir_mode():
self.assertEqual(out.dtype, base.core.DataType.FLOAT64)
self.assertEqual(out.dtype, paddle.float64)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datatype 不能改

@@ -593,9 +593,9 @@ def test_out_dtype():
shape=[3, 4], dtype='float64'
)
if paddle.framework.in_pir_mode():
self.assertEqual(out.dtype, base.core.DataType.FLOAT64)
self.assertEqual(out.dtype, paddle.float64)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上,datatype 不能改

@@ -511,7 +511,7 @@ def test_deep_copy(self):

# test copy selected rows
x = core.eager.Tensor(
core.VarDesc.VarType.FP32,
paddle.float32,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也先不要改

@SigureMo SigureMo added the HappyOpenSource 快乐开源活动issue与PR label Feb 4, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit a8550da into PaddlePaddle:develop Feb 4, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants