-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeStyle][Typos][A-[21-30]] Fix typos (allctor
,almostly
,alog
,Aread
,Allways
,alway
,ane
,adn
,expaned
,annotaions
,annotaion
,architecure
,architecuture
,aer
)
#69482
Changes from 5 commits
747b6c9
58327a3
1d01a64
bfffae8
7f85ee6
1d34cbe
9a7f204
bb172b1
3aacefb
c7ca43a
0cf3cfd
532c0d1
f3d4dd7
d447ab8
34ffc2d
c12293e
f029d13
e453c78
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -138,8 +138,8 @@ struct SearchAlgorithm<ReverseTopoNodePairPattern, | |||||
template <typename Kind, typename GraphMatcher, typename GraphOperation> | ||||||
void GraphTransformer(PatternGraph* graph) { | ||||||
VLOG(4) << "Start GraphTransformer..."; | ||||||
auto alog = SearchAlgorithm<Kind, GraphMatcher, GraphOperation>(graph); | ||||||
alog(); | ||||||
auto along = SearchAlgorithm<Kind, GraphMatcher, GraphOperation>(graph); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
自己看上下文,这不是 |
||||||
along(); | ||||||
} | ||||||
|
||||||
} // namespace cinn::fusion |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -72,7 +72,7 @@ def _default_pruning( | |||||
# In sparse training, layer weight matrices is viewed sparse matrix A, so | ||||||
# the math formula should be 'Act(WX + b)'. However, default formula in PaddlePaddle | ||||||
# is 'Act(XW + b)'. For enabling SPMMA, weights and inputs should be transposed | ||||||
# for computing, Act( (W^T X^T)^T + b). Therefore, we have to prune alog k dimension | ||||||
# for computing, Act( (W^T X^T)^T + b). Therefore, we have to prune log k dimension | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
从 71 行能看出来是 |
||||||
# of W^T, which is m dimension of W. Moreover, all mask generating functions in | ||||||
# asp/utils is row-major pruning. That is the reason we have to transpose weight | ||||||
# matrices before invoking create_mask. Then we transpose the result mask to make | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -354,7 +354,7 @@ def __init__( | |||||
self._quantized_weight_var_name = set() | ||||||
self._quantized_act_var_name = set() | ||||||
self._weight_op_pairs = {} | ||||||
# The vars for alog = KL or hist | ||||||
# The vars for along = KL or hist | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
算法 KL |
||||||
self._sampling_act_abs_min_max = {} | ||||||
self._sampling_act_histogram = {} | ||||||
self._sampling_data = {} | ||||||
|
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -86,19 +86,19 @@ TEST(GpuTimer, Sum) { | |||||||||||||
#endif | ||||||||||||||
|
||||||||||||||
using Functor = std::function<void(float *, float *, size_t)>; | ||||||||||||||
Functor alog0 = Algo<4, 256, 1024>; | ||||||||||||||
Functor algo1 = Algo<1, 256, 1024>; | ||||||||||||||
Functor alog2 = Algo<1, 256, 8>; | ||||||||||||||
Functor along0 = Along<4, 256, 1024>; | ||||||||||||||
Functor along1 = Along<1, 256, 1024>; | ||||||||||||||
Functor along2 = Along<1, 256, 8>; | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
算法算法算法, |
||||||||||||||
|
||||||||||||||
std::vector<Functor> algos = {alog0, algo1, alog2}; | ||||||||||||||
std::vector<Functor> algos = {along0, along1, along2}; | ||||||||||||||
|
||||||||||||||
for (int j = 0; j < algos.size(); ++j) { | ||||||||||||||
auto algo = algos[j]; | ||||||||||||||
phi::GpuTimer timer; | ||||||||||||||
timer.Start(0); | ||||||||||||||
algo(d_in1, d_in2, N); | ||||||||||||||
timer.Stop(0); | ||||||||||||||
VLOG(3) << "alog: " << j << " cost: " << timer.ElapsedTime() << "ms"; | ||||||||||||||
VLOG(3) << "along: " << j << " cost: " << timer.ElapsedTime() << "ms"; | ||||||||||||||
} | ||||||||||||||
|
||||||||||||||
#ifdef __HIPCC__ | ||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,7 @@ def test_train(self): | |
self.check_reader(paddle.dataset.imikolov.train(WORD_DICT, n), n) | ||
|
||
first_line = ( | ||
'aer banknote berlitz calloway centrust cluett fromstein ' | ||
'are banknote berlitz calloway centrust cluett fromstein ' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这里不能修改,因为这里本来就不是有效词汇,需要将本文件在配置中 ignore 掉 参考 crate-ci/typos#316 (comment) 配置参考 https://github.com/crate-ci/typos/blob/master/docs/reference.md#config-fields 可用 @MrXnneHang 可以在 Q&A 里提及,这种本身就是使用一些 typos 的字面量,整个文件可以 ignore There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 好。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
这个加到配置了吗?按文件加到配置 |
||
'gitano guterman hydro-quebec ipo kia memotec mlx nahb punts ' | ||
'rake regatta rubens sim snack-food ssangyong swapo wachter' | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下面的空行加回来