【Hackathon 8th No.2】为 Paddle 新增 baddbmm API #70757

Qin-sx · 2025-01-09T13:20:37Z

PR Category

User Experience

PR Types

New features

Description

https://github.com/PaddlePaddle/community/blob/master/hackathon/hackathon_8th/%E3%80%90Hackathon_8th%E3%80%91%E4%B8%AA%E4%BA%BA%E6%8C%91%E6%88%98%E8%B5%9B%E2%80%94%E6%A1%86%E6%9E%B6%E5%BC%80%E5%8F%91%E4%BB%BB%E5%8A%A1%E5%90%88%E9%9B%86.md#no2-%E4%B8%BA-paddle-%E6%96%B0%E5%A2%9E-baddbmm-api

新增加了float16和bfloat16的特例化

modified: paddle/fluid/pybind/pybind.cc modified: paddle/phi/core/memory/stats.cc modified: paddle/phi/core/memory/stats.h modified: python/paddle/device/cuda/__init__.py

modified: paddle/fluid/pybind/pybind.cc modified: python/paddle/device/cuda/__init__.py

modified: paddle/fluid/pybind/pybind.cc modified: paddle/phi/core/memory/stats.cc modified: paddle/phi/core/memory/stats.h modified: test/cpp/fluid/memory/stats_test.cc

new file: test/legacy_test/test_cuda_memory_stats.py new file: test/legacy_test/test_cuda_reset_peak_memory_stats.py

new file: test/legacy_test/test_cuda_reset_max_memory_allocated.py

modified: python/paddle/device/cuda/__init__.py modified: test/legacy_test/test_cuda_memory_stats.py modified: test/legacy_test/test_cuda_reset_max_memory_allocated.py modified: test/legacy_test/test_cuda_reset_peak_memory_stats.py

modified: paddle/fluid/pybind/pybind.cc modified: paddle/phi/core/memory/stats.cc modified: paddle/phi/core/memory/stats.h modified: test/cpp/fluid/memory/stats_test.cc

modified: python/paddle/device/cuda/__init__.py modified: test/legacy_test/test_cuda_reset_max_memory_allocated.py new file: test/legacy_test/test_cuda_reset_max_memory_reserved.py

modified: paddle/fluid/pybind/pybind.cc modified: python/paddle/device/cuda/__init__.py deleted: test/legacy_test/test_cuda_memory_stats.py deleted: test/legacy_test/test_cuda_reset_peak_memory_stats.py

modified: paddle/phi/infermeta/ternary.cc modified: paddle/phi/infermeta/ternary.h new file: paddle/phi/kernels/baddbmm_grad_kernel.h new file: paddle/phi/kernels/baddbmm_kernel.h new file: paddle/phi/kernels/cpu/baddbmm_grad_kernel.cc new file: paddle/phi/kernels/cpu/baddbmm_kernel.cc modified: paddle/phi/kernels/funcs/blas/blas.h modified: paddle/phi/kernels/funcs/blas/blas_impl.cu.h modified: paddle/phi/kernels/funcs/blas/blas_impl.h new file: paddle/phi/kernels/gpu/baddbmm_grad_kernel.cu new file: paddle/phi/kernels/gpu/baddbmm_kernel.cu new file: paddle/phi/kernels/impl/baddbmm_grad_kernel_impl.h new file: paddle/phi/kernels/impl/baddbmm_kernel_impl.h modified: paddle/phi/ops/yaml/backward.yaml modified: paddle/phi/ops/yaml/ops.yaml modified: python/paddle/__init__.py modified: python/paddle/tensor/__init__.py modified: python/paddle/tensor/math.py

modified: paddle/fluid/pir/dialect/op_generator/decomp_interface_gen_op_list.py modified: paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.cc modified: paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.h modified: paddle/fluid/primitive/decomp_rule/decomp_rule/composite.h modified: paddle/phi/api/ext/tensor_compat.h modified: paddle/phi/kernels/impl/baddbmm_grad_kernel_impl.h modified: paddle/phi/ops/yaml/op_compat.yaml new file: test/legacy_test/test_baddbmm_op.py

paddle-bot · 2025-01-09T13:20:43Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

modified: ../paddle/phi/kernels/funcs/blas/blas_impl.cu.h modified: ../paddle/phi/kernels/impl/baddbmm_kernel_impl.h

modified: ../paddle/phi/ops/yaml/ops.yaml

modified: ../test/legacy_test/test_baddbmm_op.py

modified: ../test/legacy_test/test_baddbmm_op.py new file: ../test/legacy_test/test_baddbmm_op1.py new file: ../test/legacy_test/test_baddbmm_op2.py new file: ../test/legacy_test/test_baddbmm_op3.py

modified: ../test/legacy_test/test_baddbmm_op1.py

modified: ../paddle/phi/api/ext/tensor_compat.h

modified: ../paddle/phi/kernels/funcs/blas/blas_impl.hip.h

modified: ../test/legacy_test/test_baddbmm_op3.py new file: ../test/legacy_test/test_baddbmm_op4.py

DrownFish19 · 2025-01-14T02:40:37Z

paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.cc

@@ -163,6 +163,67 @@ bool Addmm_OpInferSymbolicShape(pir::Operation *op,
  return AddmmOpInferSymbolicShape(op, infer_context);
 }

+bool BaddbmmOpInferSymbolicShape(


调整代码位置，函数名按照ABC排列

收到，已修改，谢谢

DrownFish19 · 2025-01-14T02:41:03Z

paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.h

@@ -21,6 +21,8 @@ namespace paddle::dialect {
 OP_DECLARE_INFER_SYMBOLIC_SHAPE(Accuracy)
 OP_DECLARE_INFER_SYMBOLIC_SHAPE(Addmm)
 OP_DECLARE_INFER_SYMBOLIC_SHAPE(Addmm_)
+OP_DECLARE_INFER_SYMBOLIC_SHAPE(Baddbmm)


调整代码位置，函数名按照ABC排列

收到，已修改，谢谢

DrownFish19 · 2025-01-14T02:45:16Z

paddle/phi/kernels/baddbmm_grad_kernel.h

@@ -0,0 +1,33 @@
+/* Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.


新增文件注意一下copyright 年份

收到，新增文件均已修改，谢谢

DrownFish19 · 2025-01-14T02:55:21Z

paddle/phi/kernels/funcs/blas/blas_impl.cu.h

@@ -1183,6 +1183,152 @@ inline void Blas<phi::GPUContext>::GEMM(CBLAS_TRANSPOSE transA,
 #endif  // CUDA_VERSION >= 8000
 }

+template <>
+template <typename T, typename U>


这里是否需要和.h一致 template <typename T, typename U = T>

辛苦检查同级文件

这里在模板偏特化时，应该不能再设置默认的模板参数了。
以下为报错提示：

/Paddle_2_GPU/Paddle/paddle/phi/kernels/funcs/blas/blas_impl.cu.h(1187): error: a default template argument cannot be specified on the declaration of a member of a class template outside of its class

DrownFish19 · 2025-01-14T03:21:26Z

辛苦在PR描述中补充精度验证代码和精度误差

modified: paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.cc modified: paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.h modified: paddle/phi/kernels/baddbmm_grad_kernel.h modified: paddle/phi/kernels/baddbmm_kernel.h modified: paddle/phi/kernels/cpu/baddbmm_grad_kernel.cc modified: paddle/phi/kernels/cpu/baddbmm_kernel.cc modified: paddle/phi/kernels/gpu/baddbmm_grad_kernel.cu modified: paddle/phi/kernels/gpu/baddbmm_kernel.cu modified: paddle/phi/kernels/impl/baddbmm_grad_kernel_impl.h modified: paddle/phi/kernels/impl/baddbmm_kernel_impl.h modified: test/legacy_test/test_baddbmm_op.py modified: test/legacy_test/test_baddbmm_op1.py modified: test/legacy_test/test_baddbmm_op2.py modified: test/legacy_test/test_baddbmm_op3.py modified: test/legacy_test/test_baddbmm_op4.py

modified: test/legacy_test/CMakeLists.txt modified: test/legacy_test/test_baddbmm_op.py new file: test/legacy_test/test_baddbmm_op5.py

modified: paddle/phi/kernels/funcs/blas/blas_impl.hip.h

Qin-sx · 2025-01-17T02:28:06Z

辛苦在PR描述中补充精度验证代码和精度误差

验证代码添加在了RFC文档中。

以下为测试结果：

float32类型

max diff between paddle matmul and torch baddbmm is 0.0021514892578125
max diff between paddle baddbmm and torch baddbmm is 0.0
max diff between paddle baddbmm and paddle matmul is 0.0021514892578125

float16类型

max diff between paddle matmul and torch baddbmm is 0.25
max diff between paddle baddbmm and torch baddbmm is 0.0
max diff between paddle baddbmm and paddle matmul is 0.25

bfloat16类型

max diff between paddle matmul and torch baddbmm is 2.0
max diff between paddle baddbmm and torch baddbmm is 0.0
max diff between paddle baddbmm and paddle matmul is 2.0

Qin-sx · 2025-01-17T12:16:46Z

RFC文档：【Hackathon 8th No.2】为 Paddle 新增 baddbmm API community#1051
API文档：【Hackathon 8th No.2】为 Paddle 新增 baddbmm API docs#7041

modified: paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.cc modified: paddle/phi/infermeta/ternary.cc modified: paddle/phi/kernels/impl/baddbmm_grad_kernel_impl.h modified: paddle/phi/kernels/impl/baddbmm_kernel_impl.h modified: python/paddle/tensor/math.py modified: test/legacy_test/CMakeLists.txt new file: test/legacy_test/test_baddbmm_op6.py

modified: ../paddle/phi/infermeta/ternary.cc modified: ../test/legacy_test/test_baddbmm_op3.py

modified: ../python/paddle/tensor/math.py new file: ../test/legacy_test/test_baddbmm_op7.py

modified: ../test/legacy_test/CMakeLists.txt modified: ../test/legacy_test/test_baddbmm_op7.py

modified: paddle/phi/kernels/funcs/blas/blas_impl.cu.h

Qin-sx · 2025-01-23T01:35:47Z

关于PR-CI-Coverage没有覆盖到的两部分的相关issue
#70848
#70888

DrownFish19 · 2025-01-23T03:18:53Z

python/paddle/tensor/math.py

+                raise ValueError(
+                    f"If input's dimension[2] is not equal to y's dimension[2], input's dimension[2] must be 1. But received input's dimension[2] = {input_shape[2]}, y's dimension[2] = {y_shape[2]}"
+                )
+            # 上面的判断已经包含了这种情况


注释如不必要，可以删除

收到，已修改，谢谢

DrownFish19 · 2025-01-23T03:19:09Z

python/paddle/tensor/math.py

+                raise ValueError(
+                    f"If input's dimension[2] is not equal to y's dimension[2], input's dimension[2] must be 1. But received input's dimension[2] = {input_shape[2]}, y's dimension[2] = {y_shape[2]}"
+                )
+            # 上面的判断已经包含了这种情况


注释问题

收到，已修改，谢谢

modified: ../paddle/phi/api/ext/tensor_compat.h modified: ../python/paddle/tensor/math.py

Qin-sx added 12 commits December 5, 2024 06:36

added reset peak value initialization

e2299f9

modified: paddle/fluid/pybind/pybind.cc modified: paddle/phi/core/memory/stats.cc modified: paddle/phi/core/memory/stats.h modified: python/paddle/device/cuda/__init__.py

added comments

dc30348

modified: paddle/fluid/pybind/pybind.cc modified: python/paddle/device/cuda/__init__.py

added cpp tests

d081dde

modified: paddle/fluid/pybind/pybind.cc modified: paddle/phi/core/memory/stats.cc modified: paddle/phi/core/memory/stats.h modified: test/cpp/fluid/memory/stats_test.cc

added python tests

35a12c8

new file: test/legacy_test/test_cuda_memory_stats.py new file: test/legacy_test/test_cuda_reset_peak_memory_stats.py

added a python test for reset_max_memory_allocated

cb5036c

new file: test/legacy_test/test_cuda_reset_max_memory_allocated.py

formatted by pre-commit

5d28856

modified: python/paddle/device/cuda/__init__.py modified: test/legacy_test/test_cuda_memory_stats.py modified: test/legacy_test/test_cuda_reset_max_memory_allocated.py modified: test/legacy_test/test_cuda_reset_peak_memory_stats.py

formatted by pre-commit (clang-format)

f6b3d84

modified: paddle/fluid/pybind/pybind.cc modified: paddle/phi/core/memory/stats.cc modified: paddle/phi/core/memory/stats.h modified: test/cpp/fluid/memory/stats_test.cc

added reset max memory reserved function

b6ea9be

modified: python/paddle/device/cuda/__init__.py modified: test/legacy_test/test_cuda_reset_max_memory_allocated.py new file: test/legacy_test/test_cuda_reset_max_memory_reserved.py

deleted memory stats and reset peak memory stats

caad368

modified: paddle/fluid/pybind/pybind.cc modified: python/paddle/device/cuda/__init__.py deleted: test/legacy_test/test_cuda_memory_stats.py deleted: test/legacy_test/test_cuda_reset_peak_memory_stats.py

Merge branch 'develop' of https://github.com/Qin-sx/Paddle into develop

299a7c0

paddle-bot bot added the contributor External developers label Jan 9, 2025

luotao1 added the PaddlePaddle Hackathon label Jan 10, 2025

luotao1 self-assigned this Jan 10, 2025

Qin-sx and others added 14 commits January 10, 2025 14:35

added bloat16 case

fdf6322

modified: ../paddle/phi/kernels/funcs/blas/blas_impl.cu.h modified: ../paddle/phi/kernels/impl/baddbmm_kernel_impl.h

added InferSymbolicShapeInterface

ed02d8d

modified: ../paddle/phi/ops/yaml/ops.yaml

added more tests

2b3ed56

modified: ../test/legacy_test/test_baddbmm_op.py

tests overtime (20s), reduced size

47de1e6

modified: ../test/legacy_test/test_baddbmm_op.py

test overtime again, reduced size again

da9467b

modified: ../test/legacy_test/test_baddbmm_op.py

reduce size for overtime again

85bb2f5

modified: ../test/legacy_test/test_baddbmm_op.py

just one test for overtime

39ae437

modified: ../test/legacy_test/test_baddbmm_op.py

divided tests in some files

c812aa0

modified: ../test/legacy_test/test_baddbmm_op.py new file: ../test/legacy_test/test_baddbmm_op1.py new file: ../test/legacy_test/test_baddbmm_op2.py new file: ../test/legacy_test/test_baddbmm_op3.py

enable static

284e601

modified: ../test/legacy_test/test_baddbmm_op1.py

deleted baddbmm in tensor_compat.h

c18014a

modified: ../paddle/phi/api/ext/tensor_compat.h

added float in hip

ebc6f56

modified: ../paddle/phi/kernels/funcs/blas/blas_impl.hip.h

pre-commit

cd54e10

modified: ../paddle/phi/kernels/funcs/blas/blas_impl.hip.h

added more tests

8afaf6a

modified: ../test/legacy_test/test_baddbmm_op3.py new file: ../test/legacy_test/test_baddbmm_op4.py

Merge branch 'PaddlePaddle:develop' into develop

306df76

Merge branch 'PaddlePaddle:develop' into develop

968dc8b

DrownFish19 reviewed Jan 14, 2025

View reviewed changes

luotao1 mentioned this pull request Jan 14, 2025

【Hackathon 8th】开源贡献个人挑战赛（尝鲜版） #70746

Open

Qin-sx and others added 4 commits January 14, 2025 18:50

Merge branch 'PaddlePaddle:develop' into develop

8aa753c

updated tests

a287784

modified: test/legacy_test/CMakeLists.txt modified: test/legacy_test/test_baddbmm_op.py new file: test/legacy_test/test_baddbmm_op5.py

updated blas hip

b68104b

modified: paddle/phi/kernels/funcs/blas/blas_impl.hip.h

Qin-sx added 6 commits January 19, 2025 00:10

added more tests

d06509b

modified: ../paddle/phi/infermeta/ternary.cc modified: ../test/legacy_test/test_baddbmm_op3.py

added more tests for baddbmm_

5c966a1

modified: ../python/paddle/tensor/math.py new file: ../test/legacy_test/test_baddbmm_op7.py

added more tests

c5598a5

modified: ../test/legacy_test/CMakeLists.txt modified: ../test/legacy_test/test_baddbmm_op7.py

typo

f5f1e38

modified: paddle/phi/kernels/funcs/blas/blas_impl.cu.h

Merge branch 'develop' into develop_baddbmm_format

d572d4d

DrownFish19 reviewed Jan 23, 2025

View reviewed changes

deleted comments and 'print'

9c6ac6a

modified: ../paddle/phi/api/ext/tensor_compat.h modified: ../python/paddle/tensor/math.py

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 8th No.2】为 Paddle 新增 baddbmm API #70757

【Hackathon 8th No.2】为 Paddle 新增 baddbmm API #70757

Qin-sx commented Jan 9, 2025 •

edited

Loading

paddle-bot bot commented Jan 9, 2025

DrownFish19 Jan 14, 2025

Qin-sx Jan 14, 2025

DrownFish19 Jan 14, 2025

Qin-sx Jan 14, 2025

DrownFish19 Jan 14, 2025

Qin-sx Jan 14, 2025

DrownFish19 Jan 14, 2025

DrownFish19 Jan 14, 2025

Qin-sx Jan 15, 2025

DrownFish19 commented Jan 14, 2025

Qin-sx commented Jan 17, 2025

Qin-sx commented Jan 17, 2025

Qin-sx commented Jan 23, 2025

DrownFish19 Jan 23, 2025

Qin-sx Jan 23, 2025

DrownFish19 Jan 23, 2025

Qin-sx Jan 23, 2025

		@@ -0,0 +1,33 @@
		/* Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.

【Hackathon 8th No.2】为 Paddle 新增 baddbmm API #70757

Are you sure you want to change the base?

【Hackathon 8th No.2】为 Paddle 新增 baddbmm API #70757

Conversation

Qin-sx commented Jan 9, 2025 • edited Loading

PR Category

PR Types

Description

paddle-bot bot commented Jan 9, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DrownFish19 commented Jan 14, 2025

Qin-sx commented Jan 17, 2025

Qin-sx commented Jan 17, 2025

Qin-sx commented Jan 23, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Qin-sx commented Jan 9, 2025 •

edited

Loading