Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NVIDIA] Refine API difference of all_gather_object #6892

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

anderson101866
Copy link
Contributor

@anderson101866 anderson101866 commented Sep 26, 2024

Unlike PyTorch, using paddle don't need to pre-allocate object_list to equal size of group size.

In `paddle`, no need to pre-allocate `object_list` to equal size of group size
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

@anderson101866 anderson101866 changed the title Refine API difference of all_gather_object [NVIDIA] Refine API difference of all_gather_object Sep 27, 2024
@anderson101866
Copy link
Contributor Author

New commit submitted, but the Doc-New is not triggered automatically. Do I need to do something to wake it up?
(I've manually rerun pass)

fix doc hook `insert-whitespace-between-cn-and-en-char`
@anderson101866
Copy link
Contributor Author

@sunzhongkai588, @Ligoml, @jzhang533, 再麻煩幫忙review下這個document更新。主要是為了提醒自PyTorch遷移代碼的開發者,all_gather的輸入參數初始化不同,如果沒注意可能會讓結果出錯

Copy link
Collaborator

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for doing this.

@jzhang533 jzhang533 merged commit db52460 into PaddlePaddle:develop Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants