Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv(ux): Adding support for escalation policy dropdown on custom action #6

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

t1agob
Copy link
Contributor

@t1agob t1agob commented Dec 19, 2023

Description

This PR introduces the capability of replacing the Escalation Policy ID input in the 'pagerduty:service:create' action with a drop-down with the Escalation Policies available to the user. It does so by exposing a local API that gets all escalation policies and returns a list of names and ids.

It introduces a new configuration option (apiToken) documented as part of Backstage configuration schema. Without it the plugin is unable to start but I have implemented proper warnings and error message to warn the users. It is also documented in the official documentation.

Issue number: #2

Type of change

  • New feature (non-breaking change which adds functionality)
  • Fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • Changes generate no new warnings
  • PR title follows conventional commit semantics

If this is a breaking change 👇

  • I have documented the migration process
  • I have implemented necessary warnings (if it can live side by side)

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

adds new router to query PD API to support better ux for custom action

Signed-off-by: Tiago Barbosa <[email protected]>
add config file schema to enforce input parameters

Signed-off-by: Tiago Barbosa <[email protected]>
add api route for getting escalation policies. supports frontend.

Signed-off-by: Tiago Barbosa <[email protected]>
updated wrong link to documentation

Signed-off-by: Tiago Barbosa <[email protected]>
@t1agob t1agob added the enhancement New feature or request label Dec 19, 2023
@t1agob t1agob merged commit 5bf08b6 into next Dec 19, 2023
1 check passed
@t1agob t1agob deleted the ui/escalation-policy-dropdown branch December 19, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

1 participant