Skip to content

Commit

Permalink
fix: Move react strict dependencies (#49)
Browse files Browse the repository at this point in the history
* build(react): ➖ move react dependencies to peer and dev

Strict dependencies caused installation to fail if react version doesn't match with Backstage installation version

---------

Signed-off-by: Tiago Barbosa <[email protected]>
  • Loading branch information
t1agob authored Dec 10, 2023
1 parent 271a736 commit 31bc0bc
Show file tree
Hide file tree
Showing 3 changed files with 322 additions and 436 deletions.
3 changes: 3 additions & 0 deletions backstage.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"version": "1.20.3"
}
19 changes: 12 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,20 +39,24 @@
"@backstage/errors": "^1.2.3",
"@backstage/plugin-catalog-react": "^1.9.1",
"@backstage/plugin-home-react": "^0.1.5",
"@backstage/theme": "^0.4.1",
"@backstage/theme": "^0.4.4",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
"@types/react": "^16.13.1 || ^17.0.0 || ^18.0.0",
"classnames": "^2.2.6",
"luxon": "^3.4.1",
"react-use": "^17.4.0"
"react-use": "^17.2.4"
},
"peerDependencies": {
"react": "^16.13.1 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.13.1 || ^17.0.0 || ^18.0.0",
"react-router-dom": "6.0.0-beta.0 || ^6.3.0"
},
"devDependencies": {
"@backstage/cli": "^0.22.12",
"@backstage/core-app-api": "^1.9.1",
"@backstage/dev-utils": "^1.0.20",
"@backstage/test-utils": "^1.4.2",
"@backstage/cli": "^0.24.0",
"@backstage/core-app-api": "^1.11.1",
"@backstage/dev-utils": "^1.0.24",
"@backstage/test-utils": "^1.4.5",
"@commitlint/cli": "^17.7.1",
"@commitlint/config-conventional": "^17.7.0",
"@testing-library/dom": "^8.0.0",
Expand All @@ -61,6 +65,7 @@
"@testing-library/user-event": "^14.0.0",
"@types/luxon": "^3.3.1",
"@types/node": "^16.11.26",
"@types/react": "^16.13.1 || ^17.0.0 || ^18.0.0",
"copyfiles": "^2.4.1",
"msw": "^1.2.4",
"react": "^16.13.1 || ^17.0.0 || ^18.0.0",
Expand Down
Loading

0 comments on commit 31bc0bc

Please sign in to comment.