Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errors in log entries polling logic #113

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

martindstone
Copy link

Log entries polling had some problems:

  • interval was getting reset too often (dependency array had too many things in it)
  • also it looks like the browser was caching what it thought were identical requests when we were polling and the since date had not changed -- added a random query param to bypass the cache
  • multiple log entries fetches could be started at once, that should not be possible now
  • logging as error when skipping polls just so that we can see it in RUM

I'd like to deploy this as a hotfix because the current behavior is pretty bad

@gsreynolds gsreynolds merged commit f6a0987 into develop Jun 29, 2023
13 checks passed
@gsreynolds gsreynolds deleted the hotfix-log_entries-polling branch June 29, 2023 09:34
gsreynolds added a commit that referenced this pull request Jun 29, 2023
…ercept and cy.filter in tests still matches

Signed-off-by: Gavin Reynolds <[email protected]>
@gsreynolds gsreynolds added the bug Something isn't working label Jun 29, 2023
@gsreynolds gsreynolds added this to the v0.8.2 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants