Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Custom Details added to alerts from both email and event based alerts #420

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

gsreynolds
Copy link
Member

@gsreynolds gsreynolds commented Mar 21, 2024

Fix #377

Custom details are in both body.cef_details.details and body.details for events... however body.cef_details can be null if the alert is from an email, therefore switch to only use body.details to cover both cases.

Signed-off-by: Gavin Reynolds [email protected]

…for events... however body.cef_details.details can be null if the alert is from an email

Signed-off-by: Gavin Reynolds <[email protected]>
Copy link

@martindstone martindstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and I had noticed this too... thanks!

@gsreynolds gsreynolds merged commit 2c1f9a9 into develop Mar 26, 2024
15 checks passed
@gsreynolds gsreynolds deleted the cef_details_email branch March 26, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix bug/issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alerts endpoint returns null for body.cef_details with email alerts and transformed fields are in body.details
2 participants