test(definitions): Info test review

asyncapi#539
Pakisan · Jun 12, 2024 · ac929b6 · ac929b6
1 parent 85f6522
commit ac929b6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/test/definitions/3.0.0/models/info/info/index.mjs b/test/definitions/3.0.0/models/info/info/index.mjs
@@ -5,12 +5,12 @@ import path from 'path';
 const jsonSchema = require('@definitions/3.0.0/info.json');
 
 describe('Info', () => {
-  it('example', () => TestHelper.objectIsValid(
+  it(TestHelper.exampleIsValidTestName, () => TestHelper.objectIsValid(
     jsonSchema,
     path.resolve(__dirname, './example.json'),
   ));
 
-  it('empty', () => TestHelper.objectIsNotValid(
+  it(TestHelper.cannotBeEmptyTestName, () => TestHelper.objectIsNotValid(
     jsonSchema,
     path.resolve(__dirname, './empty.json'),
     [
@@ -19,7 +19,7 @@ describe('Info', () => {
     ]
   ));
 
-  it('without required properties', () => TestHelper.objectIsNotValid(
+  it(TestHelper.isNotValidWithoutRequiredPropertiesTestName, () => TestHelper.objectIsNotValid(
     jsonSchema,
     path.resolve(__dirname, './without required properties.json'),
     [
@@ -28,17 +28,17 @@ describe('Info', () => {
     ]
   ));
 
-  it('only required properties', () => TestHelper.objectIsValid(
+  it(TestHelper.isValidWithOnlyRequiredPropertiesTestName, () => TestHelper.objectIsValid(
     jsonSchema,
     path.resolve(__dirname, './only required properties.json'),
   ));
 
-  it('extended', () => TestHelper.objectIsValid(
+  it(TestHelper.isValidWhenIsExtendedTestName, () => TestHelper.objectIsValid(
     jsonSchema,
     path.resolve(__dirname, './extended.json'),
   ));
 
-  it('wrongly extended', () => TestHelper.wronglyExtended(
+  it(TestHelper.isNotValidWhenIsWronglyExtendedTestName, () => TestHelper.wronglyExtended(
     jsonSchema,
     path.resolve(__dirname, './wrongly extended.json')
   ));

diff --git a/test/test-helper.mjs b/test/test-helper.mjs
@@ -16,10 +16,18 @@ export default class TestHelper {
     return 'can be empty';
   }
 
+  static get cannotBeEmptyTestName() {
+    return 'cannot be empty';
+  }
+
   static get isValidWithoutRequiredPropertiesTestName() {
     return 'is valid without required properties';
   }
 
+  static get isNotValidWithoutRequiredPropertiesTestName() {
+    return 'is not valid without required properties';
+  }
+
   static get isValidWithOnlyRequiredPropertiesTestName() {
     return 'is valid with only required properties';
   }