Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add penpot-desktop #3687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

titus-pinta
Copy link

I have added icons for the pwa version of penpot (https://design.penpot.app/) because the default one does not respect the color scheme of Papirus.

Thank you for looking into this,
Titus

@achadwick
Copy link
Contributor

[would close #3286]

Hi, @titus-pinta, and thanks for your interest.

This PR can't be accepted right now because the automated tests don't pass: some of the icon sizes are not exact pixel boundaries. The icon also needs redrawing so that all the outer lines and as much of the inner lines of the logo align on pixel boundaries. This can be quite tricky, so there are some guidelines:

The base shape of the icon needs a highlight and a shadow too. That should be covered in the docs above.

$ make test-all 
make -C "../.." test-all
make[1]: Entering directory '[...]/papirus-icon-theme'
# >>> Searching for icons with rendering glitches
# >>> Searching for non-optimized icons
# >>> Searching for icons with embedded objects
# >>> Searching for broken symlinks
# >>> Searching for invalid icon names
# >>> Detecting decimal numbers in width/height/viewBox attrs
Papirus/24x24/apps/penpot-desktop.svg
Papirus/64x64/apps/penpot-desktop.svg
Papirus/16x16/apps/penpot-desktop.svg
Papirus/48x48/apps/penpot-desktop.svg
Papirus/22x22/apps/penpot-desktop.svg
Papirus/32x32/apps/penpot-desktop.svg
make[1]: *** [Makefile:73: test_decimal_size] Error 1
make[1]: Leaving directory '[...]/papirus-icon-theme'
make: *** [Makefile:22: test-all] Error 2

Let us know if you want to have a go at fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants