Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated GRAPPA Transpose implementation, Introduce new grappa kernels, and fix whitespace #94

Closed
wants to merge 67 commits into from
Closed

Updated GRAPPA Transpose implementation, Introduce new grappa kernels, and fix whitespace #94

wants to merge 67 commits into from

Conversation

jpaberc
Copy link
Contributor

@jpaberc jpaberc commented Apr 7, 2016

  • We have updated transpose to use the new additive algorithm.
  • Introducing Grappa implementations of the Random, Synch_global and Nstream kernels.
  • GRAPPA Makefiles have fixed white space and removed "-O3" optimization.
  • Kernels/Makefile now includes all GRAPPA kernels.

jpaberc and others added 30 commits June 29, 2015 16:35
Changes to GRAPPA Makefiles and GRAPPA.defs from Jacob's pull request.
c8f40e8 
 Committer: jpaberc <[email protected]>
 Changes to be committed:
	modified:   GRAPPA/Stencil/Makefile
	modified:   GRAPPA/Synch_p2p/Makefile
	modified:   common/GRAPPA.defs
	modified:   common/make.defs.in
included PRK random num generator
f53345b
command args and tests
83588e4
most recent
176c97e
forall parameter error
07bdda8
added verification step and updated comments
ff72a81
updated 'make allgrappa'
1992746
contains 3 grappa streams
3e0c6ff
random vector no longer global
91e84f9
removed unnecessary test
4dbcbf9
speed boost & improved timing mechanism
a704550
buffered random working, added barrier around kernels
3178c80
@nelsonje
remove accidentally-added stats.json
0c79402
performance improvements
6df7874
@nelsonje
Merge branch 'master' of github.com:uwsampa/Kernels
1e0c90e
variations with heavy Grappa calls outside iter loop
1087a9b
@nelsonje
Merge branch 'master' of github.com:uwsampa/Kernels
ca3255b
@nelsonje
rename stencil implementations so non-collective one is default. Add …
e70f33a 
…README.
@nelsonje
whoops, added wrong onallcores version; remove for now
2ce13f3
parallel transpose (currently invalid)
491d10e
Merge branch 'master' of https://github.com/uwsampa/Kernels
026b0b5
introducing transpose benchmark
2d1933e
introducing transpose benchmark
c074ddc
now valid
535a6aa
introduce chunked writes
f2843d4
fixed case errors
855b535
removed comment
1c8c9ad
GlobalCompletionEvent synchronization
e8fd715
added self validation. fixed non-tiling on odd Tile_orders. timing fi…
2d22723 
…xed to include appropriate number of iterations.
Merge branch 'master' of https://github.com/uwsampa/Kernels
6471cee
nelsonje and others added 21 commits March 22, 2016 01:03
@nelsonje
rename stencil implementations so non-collective one is default. Add …
f1fa536 
…README.
@nelsonje
whoops, added wrong onallcores version; remove for now
8fe4995
parallel transpose (currently invalid)
17fbb22
introducing transpose benchmark
05f7d9d
introducing transpose benchmark
20ffb83
introduce chunked writes
94cf83b
fixed case errors
c138798
removed comment
a6f1e98
GlobalCompletionEvent synchronization
742b784
added self validation. fixed non-tiling on odd Tile_orders. timing fi…
d5b55a2 
…xed to include appropriate number of iterations.
removed unnecessary code and comments
0785616
ready to send pull request
ca9b474
erge with origin/master
3fccbb4
removed MPI folder
dde1072
Merge branch 'master' of https://github.com/ParRes/Kernels
519f5f3
removed trailing whitespace
e8dc4cc
updated make allgrappa and clean to include all grappa kernels
abb1e15
fixed missing semicolon in Makefile
a35e6eb
removed make.defs to follow PRK
3c56429
local work clean-up
f49d486
removed -O3 from individual Makefiles. done by default
97c7143
@jeffhammond
Copy link
Member

Neat! Thank for you for this. @rfvander and I are overloaded right now and may not make progress on your pull request as quickly as we would all like, but we will not forget about it.

I think Travis for Grappa isn't working on our end. I might start by trying to fix that, since I'd much rather outsource the testing of this commits to AWS than run it manually on my machine.

@jeffhammond jeffhammond self-assigned this May 29, 2016
@jeffhammond
Copy link
Member

I will try to resolve this PR this week.

@jeffhammond
Copy link
Member

Sorry for the delay. I've merged your PR with all recent changes and will work on getting Travis working. See https://github.com/jeffhammond/PRK/tree/grappa-updates for details.

@jeffhammond
Copy link
Member

@jpaberc How do I run these successfully?

I have a 36-core workstation with 64 GB and am unable to run mpirun -n 36 GRAPPA/Transpose/transpose 10 36000 32 with any value of --locale_shared_fraction that I've tried so far. I can run this problem trivially with MPI1. Related: uwsampa/grappa#266.

When I run toy problems (e.g. mpirun -n 1 GRAPPA/Transpose/transpose 10 3600 32), Grappa fails on exit with uwsampa/grappa#276.

@jeffhammond jeffhammond mentioned this pull request Jul 5, 2016
Merged
@jeffhammond
Copy link
Member

I am going to close this in favor of #116 but I have to mark Grappa as XFAIL because of the aforementioned issues 😞

@jeffhammond jeffhammond closed this Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jeffhammond jeffhammond

Labels
Grappa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpaberc @jeffhammond @nelsonje