-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated GRAPPA Transpose implementation, Introduce new grappa kernels, and fix whitespace #94
Conversation
jpaberc
commented
Apr 7, 2016
- We have updated transpose to use the new additive algorithm.
- Introducing Grappa implementations of the Random, Synch_global and Nstream kernels.
- GRAPPA Makefiles have fixed white space and removed "-O3" optimization.
- Kernels/Makefile now includes all GRAPPA kernels.
Committer: jpaberc <[email protected]> Changes to be committed: modified: GRAPPA/Stencil/Makefile modified: GRAPPA/Synch_p2p/Makefile modified: common/GRAPPA.defs modified: common/make.defs.in
…xed to include appropriate number of iterations.
…xed to include appropriate number of iterations.
Neat! Thank for you for this. @rfvander and I are overloaded right now and may not make progress on your pull request as quickly as we would all like, but we will not forget about it. I think Travis for Grappa isn't working on our end. I might start by trying to fix that, since I'd much rather outsource the testing of this commits to AWS than run it manually on my machine. |
I will try to resolve this PR this week. |
Sorry for the delay. I've merged your PR with all recent changes and will work on getting Travis working. See https://github.com/jeffhammond/PRK/tree/grappa-updates for details. |
@jpaberc How do I run these successfully? I have a 36-core workstation with 64 GB and am unable to run When I run toy problems (e.g. |
I am going to close this in favor of #116 but I have to mark Grappa as XFAIL because of the aforementioned issues 😞 |