update jaccard comments

ParabolInc · Feb 12, 2025 · d697028 · d697028
1 parent fab482d
commit d697028
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/packages/client/utils/smartGroup/computeJaccardDistanceMatrix.ts b/packages/client/utils/smartGroup/computeJaccardDistanceMatrix.ts
@@ -1,5 +1,4 @@
 /**
- * Example: computeJaccardDistanceMatrix(reflections)
  * For each pair of reflections, measure how many words they share
  * vs. how many unique words total. (Jaccard similarity = intersection/union).
  * We then use distance = 1 - similarity and feed that to clusterfck.
@@ -28,7 +27,7 @@ const jaccardDistance = (aTokens: string[], bTokens: string[]): number => {
   const setB = new Set(bTokens)
   const intersectionSize = [...setA].filter((x) => setB.has(x)).length
   const unionSize = new Set([...setA, ...setB]).size
-  if (unionSize === 0) return 0 // edge case, treat empty union as identical
+  if (unionSize === 0) return 0 // edge case, treat empty union as identical although reflections should always have text
   const similarity = intersectionSize / unionSize
   const distance = 1 - similarity
   return distance

diff --git a/packages/client/utils/smartGroup/groupReflections.ts b/packages/client/utils/smartGroup/groupReflections.ts
@@ -14,7 +14,6 @@ const groupReflections = <
   groupingOptions: GroupingOptions
 ) => {
   const reflectionTexts = reflections.map((r) => r.plaintextContent || '')
-
   const distanceMatrix = computeJaccardDistanceMatrix(reflectionTexts)
 
   const {
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,7 +14,6 @@ const groupReflections = < @@
       groupingOptions: GroupingOptions
     ) => {
       const reflectionTexts = reflections.map((r) => r.plaintextContent || '')
       const distanceMatrix = computeJaccardDistanceMatrix(reflectionTexts)
       const {
@@ Expand Down @@