Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs in TipTap Reflection editor #10636

Merged
merged 10 commits into from
Jan 7, 2025
Merged

Conversation

mattkrick
Copy link
Member

Description

This fixes the following bugs discovered during the retro we had on staging before Christmas:

  • Scroll container on unanonymous reflections does not include name
  • Hitting # does not suggest Task Tags
  • Headings on Reflections have proper line-height
  • Link Modal pops up on top of Reflection
  • Block quotes have style
  • An error pops up when the reflection JSON length exceeds 2000 chars
  • On safari, draggin a reflection doesn't trigger highlighting around the whole phase
  • If user 1 has spotlight open & the facilitator navigates back a phase, user 1 doesn't automatically follow the facilitator
  • When making a heading, list, codeblock or block quote, hitting enter does not submit. You must hit Enter 1 time to get out out of the mark, then again to submit
  • Group titles remove linebreaks
  • Long words and links get wrapped for emails
  • Cannot submit an empty reflection
  • Vote phase is user-select: none (does not show a caret when hovering a card)

@github-actions github-actions bot added the size/m label Jan 7, 2025
@mattkrick mattkrick merged commit 8fbfd15 into master Jan 7, 2025
7 checks passed
@mattkrick mattkrick deleted the fix/tiptap-reflection-bugs1 branch January 7, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant