Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use canonical image storage path helper func #10829

Conversation

jordanh
Copy link
Contributor

@jordanh jordanh commented Feb 7, 2025

Description

Fixes #10828

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • Can migrate down
  • Can migrate up

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@github-actions github-actions bot requested a review from tianrunhe February 7, 2025 18:49
@github-actions github-actions bot added the size/s label Feb 7, 2025
@jordanh jordanh added Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved and removed size/s labels Feb 7, 2025
@jordanh jordanh requested review from rafaelromcar-parabol and removed request for tianrunhe February 7, 2025 18:49
@jordanh jordanh self-assigned this Feb 7, 2025
@rafaelromcar-parabol rafaelromcar-parabol merged commit 32f432f into master Feb 7, 2025
8 checks passed
@rafaelromcar-parabol rafaelromcar-parabol deleted the fix/10828/ilikeiwishiwonder-template-image-helper branch February 7, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Migration not working with GCP GCS as file store provider, making it impossible to deploy using GCP GCS
2 participants