fix: empty discussion stages #10836
Open
fix: empty discussion stages #10836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dschoordsch
requested changes
Feb 11, 2025
Comment on lines
20
to
27
| const groupReflectionCounts = reflections.reduce((counts: Record<string, number>, reflection) => { | ||
| counts[reflection.reflectionGroupId] = (counts[reflection.reflectionGroupId] || 0) + 1 | ||
| return counts | ||
| }, {}) | ||
|
|
||
| const activeGroups = reflectionGroups.filter( | ||
| (group) => (groupReflectionCounts[group.id] ?? 0) > 0 | ||
| ) |
There was a problem hiding this comment.
-1 we already call removeEmptyReflections in handleCompletedRetrospectiveStage,
We should also remove empty reflection groups there, i.e. set them to
isActive: false.Otherwise if we cannot rely on this field being accurate when calling the
retroReflectionGroupsByMeetingId loader, then we should get rid of the field completely and modify the loader to do a join with reflections to check there are some in the group.
There was a problem hiding this comment.
Thanks, makes sense. I've updated removeEmptyReflections to set reflection groups to be inactive if they don't contact any reflections
There was a problem hiding this comment.
Why do we still need this logic here?
There was a problem hiding this comment.
Thanks, removed!
Dschoordsch
requested changes
Feb 13, 2025
Comment on lines
20
to
27
| const groupReflectionCounts = reflections.reduce((counts: Record<string, number>, reflection) => { | ||
| counts[reflection.reflectionGroupId] = (counts[reflection.reflectionGroupId] || 0) + 1 | ||
| return counts | ||
| }, {}) | ||
|
|
||
| const activeGroups = reflectionGroups.filter( | ||
| (group) => (groupReflectionCounts[group.id] ?? 0) > 0 | ||
| ) |
There was a problem hiding this comment.
Why do we still need this logic here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10799
Demo: https://www.loom.com/share/ed780b147c314f5ea88bcf632441ed7c
To test