Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes robotics being able to access scichem, but not RND on Kerberos #22165

Closed
wants to merge 3 commits into from

Conversation

Miraviel
Copy link
Contributor

@Miraviel Miraviel commented Aug 30, 2023

What Does This PR Do

Fixes robotics being able to access scichem but not RND windows. Fixes #22124 fixes #22125

Why It's Good For The Game

Inconsistency, now these airlocks use the same access as the other maps

Images of changes

dreamseeker_bKdgifo9aV.mp4

Testing

Compiled, bumped airlocks

Changelog

🆑
fix: Robotics can no longer access science chemistry on Delta, but can access RND windows.
/:cl:

@Henri215
Copy link
Member

image

Add a "Fixes" to the second one too

Copy link
Contributor

@Git-GoR Git-GoR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The windoor that leads to the research hallway still has the old Toxins access, you may want to change it as well.
imagen

Also, you might want to make use of access helpers instead. There's even new ones for windoors that work by matching the dir variable of the helper and door. You can find them under /obj/effect/mapping_helpers/airlock/access and .../airlock/windoor/access.

It's good to get used to using them, but it's not a big deal as eventually a PR will be made changing all varedited accesses into helpers.

@Miraviel
Copy link
Contributor Author

The windoor that leads to the research hallway still has the old Toxins access, you may want to change it as well.

Also, you might want to make use of access helpers instead. There's even new ones for windoors that work by matching the dir variable of the helper and door. You can find them under /obj/effect/mapping_helpers/airlock/access and .../airlock/windoor/access.

Fixed

I didn't want to use access helpers since nowhere else on the map we use them, other than the directional free-access ones

Copy link
Contributor

@Git-GoR Git-GoR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fair. PR #22168 has already been opened to deal with that, and yours will most likely be merged before it.

LGTM.

@ParadiseSS13-Bot ParadiseSS13-Bot added DeltaStation This PR will edit the map DeltaStation (Kerberos) -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map labels Aug 31, 2023
@Miraviel Miraviel closed this Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally DeltaStation This PR will edit the map DeltaStation (Kerberos) Map Edit This PR will modify a map
Projects
None yet
4 participants