Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap APC in maintenance Atmos Rooms with Air Alarms to make them more accessible. (Fix mistake) #22258

Closed
wants to merge 3 commits into from

Conversation

Venuska1117
Copy link
Contributor

@Venuska1117 Venuska1117 commented Sep 5, 2023

What Does This PR Do

This PR changed reworked areas "Atmospheric Maintenance" rooms to have APC's outside them, and Air alarm inside, when i first made them i never played engineering once, so i tought engineers have atmos access (with i learned they don't) so i made this PR to fix my mistake.

Why It's Good For The Game

Give easy access to APC's and Atmos Rooms have all Atmos-related stuff, now APC's would be more easy to find, considering this room is engineering-related.

Images of changes

image

Testing

Did a run to check for errors, compile properly.

Changelog

🆑 Venuska1117
tweak: All APC's inside "Atmospheric Maintenance" rooms got moved outside Rooms, now they are more accessible.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added BoxStation This PR will edit the map BoxStation (Cyberiad) -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map labels Sep 5, 2023
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 6, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally DeltaStation This PR will edit the map DeltaStation (Kerberos) MetaStation This PR will edit the map MetaStation (Cerebron) CereStation This PR edits the map CereStation (Farragus) -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Sep 6, 2023
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Sep 8, 2023
Copy link
Member

@Henri215 Henri215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Sep 19, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added SQL Change This PR modifies the game database. This PR must go through the host. Configuration Change This PR changes the game configuration files. Please run via the host. Sprites This PR modifies the game sprites Sound This PR modifies the game sound TGUI This PR modifies TGUI, will conflict labels Sep 20, 2023
@Venuska1117
Copy link
Contributor Author

okay this PR just corrupted, closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team BoxStation This PR will edit the map BoxStation (Cyberiad) CereStation This PR edits the map CereStation (Farragus) Configuration Change This PR changes the game configuration files. Please run via the host. DeltaStation This PR will edit the map DeltaStation (Kerberos) Map Edit This PR will modify a map MetaStation This PR will edit the map MetaStation (Cerebron) Sound This PR modifies the game sound Sprites This PR modifies the game sprites SQL Change This PR modifies the game database. This PR must go through the host. TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants